Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(553)

Issue 2861933002: [MD settings] .settings-row to elide content exception URL (Closed)

Created:
3 years, 7 months ago by dschuyler
Modified:
3 years, 7 months ago
Reviewers:
hcarmona
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[MD settings] .settings-row to elide content exception URL This CL changes the class of the content settings exceptions to use a max-width of 100% which allows the text elision to correctly truncate the URL. BUG=717883 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2861933002 Cr-Commit-Position: refs/heads/master@{#469428} Committed: https://chromium.googlesource.com/chromium/src/+/f32f0b0adf54be179edcb3ea613a85ee90cd078a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M chrome/browser/resources/settings/settings_shared_css.html View 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/browser/resources/settings/site_settings/site_list.html View 2 chunks +1 line, -2 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
dschuyler
.settings-row is in settings_shared_css because I intend to use it in more places in the ...
3 years, 7 months ago (2017-05-04 01:12:42 UTC) #5
hcarmona
LGTM
3 years, 7 months ago (2017-05-04 19:30:46 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2861933002/1
3 years, 7 months ago (2017-05-04 19:35:32 UTC) #10
commit-bot: I haz the power
3 years, 7 months ago (2017-05-04 19:41:37 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/f32f0b0adf54be179edcb3ea613a...

Powered by Google App Engine
This is Rietveld 408576698