Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1313)

Issue 2861903002: Revert "[infra] Roll clang to match the version used by Flutter" (Closed)

Created:
3 years, 7 months ago by zra
Modified:
3 years, 7 months ago
Reviewers:
siva
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "[infra] Roll clang to match the version used by Flutter" This reverts commit 6bf2c800fda97d21c439ee8e6d3decc8d2b727c6. There is still some strangeness with the new GN binary not wanting to do an incremental build on top of a build that used an old GN binary. Committed: https://github.com/dart-lang/sdk/commit/ab422ad19409fc6d79484754e4b016b5000933a4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1801 lines, -300 lines) Patch
M DEPS View 7 chunks +121 lines, -16 lines 0 comments Download
M build/config/android/config.gni View 2 chunks +2 lines, -6 lines 0 comments Download
M build/config/compiler/BUILD.gn View 5 chunks +34 lines, -22 lines 0 comments Download
M build/toolchain/android/BUILD.gn View 1 chunk +1 line, -10 lines 0 comments Download
M build/toolchain/linux/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M build/toolchain/mac/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
D tools/android/VERSION_LINUX_NDK View 1 chunk +0 lines, -1 line 0 comments Download
D tools/android/VERSION_LINUX_SDK View 1 chunk +0 lines, -1 line 0 comments Download
D tools/android/VERSION_MACOSX_NDK View 1 chunk +0 lines, -1 line 0 comments Download
D tools/android/VERSION_MACOSX_SDK View 1 chunk +0 lines, -1 line 0 comments Download
D tools/android/download_android_tools.py View 1 chunk +0 lines, -104 lines 0 comments Download
M tools/build.py View 1 chunk +1 line, -1 line 0 comments Download
D tools/buildtools/linux64/clang-format View 1 chunk +0 lines, -20 lines 0 comments Download
D tools/buildtools/mac/clang-format View 1 chunk +0 lines, -20 lines 0 comments Download
D tools/buildtools/update.py View 1 chunk +0 lines, -88 lines 0 comments Download
D tools/buildtools/win/clang-format.exe.sha1 View 1 chunk +0 lines, -2 lines 0 comments Download
A tools/clang/scripts/update.py View 1 chunk +909 lines, -0 lines 0 comments Download
A tools/clang/scripts/update.sh View 1 chunk +724 lines, -0 lines 0 comments Download
M tools/gn.py View 2 chunks +4 lines, -2 lines 0 comments Download
M tools/ninja.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
zra
TBR
3 years, 7 months ago (2017-05-03 22:56:05 UTC) #2
zra
Committed patchset #1 (id:1) manually as ab422ad19409fc6d79484754e4b016b5000933a4 (presubmit successful).
3 years, 7 months ago (2017-05-03 22:56:29 UTC) #4
siva
3 years, 7 months ago (2017-05-04 05:11:23 UTC) #5
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698