Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(986)

Unified Diff: tools/gn.py

Issue 2861903002: Revert "[infra] Roll clang to match the version used by Flutter" (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/clang/scripts/update.sh ('k') | tools/ninja.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn.py
diff --git a/tools/gn.py b/tools/gn.py
index 59142ba5374cd989f9f733729e5fa4c7eaf694a1..3f4345ef1729d8275547ae7383e34f120c2ffb63 100755
--- a/tools/gn.py
+++ b/tools/gn.py
@@ -165,8 +165,10 @@ def to_gn_args(args, mode, arch, target_os):
# TODO(zra): Investigate using clang with these configurations.
# Clang compiles tcmalloc's inline assembly for ia32 on Linux wrong, so we
# don't use clang in that configuration. Thus, we use gcc for ia32 *unless*
- # a clang-based sanitizer is specified.
+ # asan or tsan is specified.
has_clang = (host_os != 'win'
+ and args.os not in ['android']
+ and not gn_args['target_cpu'].startswith('arm')
and not gn_args['target_cpu'].startswith('mips')
and not ((gn_args['target_os'] == 'linux')
and (gn_args['host_cpu'] == 'x86')
@@ -246,7 +248,7 @@ def process_options(args):
if os_name != 'android':
print "Unsupported target os %s" % os_name
return False
- if not HOST_OS in ['linux', 'macos']:
+ if not HOST_OS in ['linux']:
print ("Cross-compilation to %s is not supported on host os %s."
% (os_name, HOST_OS))
return False
« no previous file with comments | « tools/clang/scripts/update.sh ('k') | tools/ninja.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698