Deprecate remove_rewritelength flag.

Deprecate remove_rewritelength flag.

This cl merges server change 154325175 by yasong.

BUG=488484
Review-Url: https://codereview.chromium.org/2861893002
Cr-Commit-Position: refs/heads/master@{#469463}
Committed: https://chromium.googlesource.com/chromium/src/+/1e4814ea23696171d50c1368ac2c37891db5e77a

[dahollings, 2017-05-03 22:21:46]

The CQ bit was checked by dahollings@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-03 22:22:14]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-03 22:35:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-03 22:35:16]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[dahollings, 2017-05-03 22:43:18]

The CQ bit was checked by dahollings@chromium.org to run a CQ dry run

[dahollings, 2017-05-03 22:43:50]

Patchset #1 (id:1) has been deleted

[commit-bot: I haz the power, 2017-05-03 22:44:17]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-03 23:59:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-03 23:59:01]

Dry run: This issue passed the CQ dry run.

[dahollings, 2017-05-04 17:13:07]

dahollings@chromium.org changed reviewers:
+ yasong@chromium.org

[dahollings, 2017-05-04 17:45:41]

Description was changed from

==========
Deprecate remove_rewritelength flag.

This cl merges server change 154325175 by yasong.

BUG=488484
==========

to

==========
Deprecate remove_rewritelength flag.

This cl merges server change 154325175 by yasong.

BUG=488484
==========

[dahollings, 2017-05-04 17:45:41]

dahollings@chromium.org changed reviewers:
+ diannahu@chromium.org
- yasong@chromium.org

[diannahu, 2017-05-04 19:31:51]

lgtm

LGTM with nit.

https://codereview.chromium.org/2861893002/diff/20001/net/spdy/core/spdy_fram...
File net/spdy/core/spdy_frame_builder.cc (right):

https://codereview.chromium.org/2861893002/diff/20001/net/spdy/core/spdy_fram...
net/spdy/core/spdy_frame_builder.cc:75: offset_ += length_;
nit: Server-side still has a SPDY_BUG here.

[dahollings, 2017-05-04 19:34:37]

The CQ bit was checked by dahollings@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-04 19:35:09]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dahollings, 2017-05-04 19:35:10]

On 2017/05/04 19:31:51, diannahu wrote:
> lgtm
> 
> LGTM with nit.
> 
>
https://codereview.chromium.org/2861893002/diff/20001/net/spdy/core/spdy_fram...
> File net/spdy/core/spdy_frame_builder.cc (right):
> 
>
https://codereview.chromium.org/2861893002/diff/20001/net/spdy/core/spdy_fram...
> net/spdy/core/spdy_frame_builder.cc:75: offset_ += length_;
> nit: Server-side still has a SPDY_BUG here.

nice catch!

[diannahu, 2017-05-04 19:38:24]

lgtm

[dahollings, 2017-05-04 19:39:14]

The CQ bit was unchecked by dahollings@chromium.org

[dahollings, 2017-05-04 19:39:15]

The CQ bit was checked by dahollings@chromium.org

[commit-bot: I haz the power, 2017-05-04 19:39:47]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-04 19:39:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-04 19:39:49]

No L-G-T-M from a valid reviewer yet.
CQ run can only be started once the patch has received an L-G-T-M from a full
committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,_not_ a
full super star committer.
Committers are members of the group "project-chromium-committers".
Note that this has nothing to do with OWNERS files.

[dahollings, 2017-05-04 19:55:23]

dahollings@chromium.org changed reviewers:
+ xunjieli@chromium.org

[dahollings, 2017-05-04 19:55:23]

+xunjieli as rubber-stamper while bnc@ is OOO

[xunjieli, 2017-05-04 20:50:15]

lgtm

[dahollings, 2017-05-04 20:51:42]

The CQ bit was checked by dahollings@chromium.org

[commit-bot: I haz the power, 2017-05-04 20:52:11]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-04 20:57:51]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1493931102217700,
"parent_rev": "14fb44e3336230da008526506b10246140b5bde0", "commit_rev":
"1e4814ea23696171d50c1368ac2c37891db5e77a"}

[commit-bot: I haz the power, 2017-05-04 20:58:07]

Description was changed from

==========
Deprecate remove_rewritelength flag.

This cl merges server change 154325175 by yasong.

BUG=488484
==========

to

==========
Deprecate remove_rewritelength flag.

This cl merges server change 154325175 by yasong.

BUG=488484

Review-Url: https://codereview.chromium.org/2861893002
Cr-Commit-Position: refs/heads/master@{#469463}
Committed:
https://chromium.googlesource.com/chromium/src/+/1e4814ea23696171d50c1368ac2c...
==========

[commit-bot: I haz the power, 2017-05-04 20:58:09]

Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/1e4814ea23696171d50c1368ac2c...