Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(418)

Issue 2861873004: Make the pref_service in TestShellDelegate injectable. (Closed)

Created:
3 years, 7 months ago by afakhry
Modified:
3 years, 7 months ago
Reviewers:
James Cook
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Make the pref_service in TestShellDelegate injectable. This lets tests interested in testing features related to the prefs_services inject their own into TestShellDelegate and register in it whatever prefs they want. BUG=718472 Review-Url: https://codereview.chromium.org/2861873004 Cr-Commit-Position: refs/heads/master@{#469387} Committed: https://chromium.googlesource.com/chromium/src/+/7093bce085613efd785b72f2a66ee8be27f7d6ed

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -6 lines) Patch
M ash/test/test_shell_delegate.h View 3 chunks +6 lines, -2 lines 0 comments Download
M ash/test/test_shell_delegate.cc View 3 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
afakhry
James, can you please review? Thank you!
3 years, 7 months ago (2017-05-04 17:15:18 UTC) #2
James Cook
lgtm
3 years, 7 months ago (2017-05-04 17:28:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2861873004/1
3 years, 7 months ago (2017-05-04 17:36:06 UTC) #5
commit-bot: I haz the power
3 years, 7 months ago (2017-05-04 18:22:48 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/7093bce085613efd785b72f2a66e...

Powered by Google App Engine
This is Rietveld 408576698