Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(485)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2861843003: Add Flash to UKM entry list (Closed)

Created:
3 years, 7 months ago by rkaplow
Modified:
3 years, 7 months ago
Reviewers:
tommycli, rkaplow1
CC:
chromium-reviews, asvitkine+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add Flash to UKM entry list BUG=704688 Review-Url: https://codereview.chromium.org/2861843003 Cr-Commit-Position: refs/heads/master@{#469149} Committed: https://chromium.googlesource.com/chromium/src/+/f4063d939f75d7858172f7a0558b3873697d9b1e

Patch Set 1 #

Total comments: 1

Patch Set 2 : reword2 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M tools/metrics/ukm/ukm.xml View 1 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
rkaplow
3 years, 7 months ago (2017-05-03 21:22:38 UTC) #3
tommycli
lgtm with revision... it's recorded once per instance, not per page load. Thanks https://codereview.chromium.org/2861843003/diff/1/tools/metrics/ukm/ukm.xml File ...
3 years, 7 months ago (2017-05-03 21:24:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2861843003/20001
3 years, 7 months ago (2017-05-03 21:42:47 UTC) #7
commit-bot: I haz the power
3 years, 7 months ago (2017-05-03 21:58:34 UTC) #10
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/f4063d939f75d7858172f7a0558b...

Powered by Google App Engine
This is Rietveld 408576698