Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Issue 2861833002: Use constexpr TaskTraits constructor in base. (Closed)

Created:
3 years, 7 months ago by fdoray
Modified:
3 years, 7 months ago
Reviewers:
gab
CC:
chromium-reviews, tracing+reviews_chromium.org, wfh+watch_chromium.org, danakj+watch_chromium.org, vmpstr+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Use constexpr TaskTraits constructor in base. Use a constexpr constructor that accepts traits in any order instead of the builder pattern to construct TaskTraits in base. BUG=713683 R=gab@chromium.org Review-Url: https://codereview.chromium.org/2861833002 Cr-Commit-Position: refs/heads/master@{#469167} Committed: https://chromium.googlesource.com/chromium/src/+/2524b542c3053e57d0c70593d26c86ef4785f881

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -7 lines) Patch
M base/test/scoped_task_scheduler.h View 1 chunk +1 line, -2 lines 0 comments Download
M base/trace_event/trace_log.cc View 1 chunk +2 lines, -5 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
fdoray
3 years, 7 months ago (2017-05-03 20:15:11 UTC) #1
fdoray
gab@: PTAL The change will then be TBRed to the owner.
3 years, 7 months ago (2017-05-03 20:15:13 UTC) #3
gab
lgtm
3 years, 7 months ago (2017-05-03 20:26:26 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2861833002/1
3 years, 7 months ago (2017-05-03 20:35:57 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2861833002/1
3 years, 7 months ago (2017-05-03 20:44:32 UTC) #11
commit-bot: I haz the power
3 years, 7 months ago (2017-05-03 22:26:23 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/2524b542c3053e57d0c70593d26c...

Powered by Google App Engine
This is Rietveld 408576698