third_party/WebKit/Source/core/layout/LayoutTableSection.cpp - Issue 2861773004: Move border-*-width out of BorderValue and store on SurroundData in ComputedStyle instead

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutTableSection.cpp

Issue 2861773004: Move border-*-width out of BorderValue and store on SurroundData in ComputedStyle instead (Closed)

Patch Set: meade@'s suggestion Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/LayoutTableSection.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutTableSection.cpp b/third_party/WebKit/Source/core/layout/LayoutTableSection.cpp

index 275532bb4fd737759e67a6f72a4a27292d04d4dc..12bac45816313d246849d6f087911212e49f001b 100644

--- a/third_party/WebKit/Source/core/layout/LayoutTableSection.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutTableSection.cpp

@@ -1757,7 +1757,7 @@ unsigned LayoutTableSection::NumEffectiveColumns() const {

return result + 1;

}

-const BorderValue& LayoutTableSection::BorderAdjoiningStartCell(

+BorderValue LayoutTableSection::BorderAdjoiningStartCell(

const LayoutTableCell* cell) const {

#if DCHECK_IS_ON()

DCHECK(cell->IsFirstOrLastCellInRow());

@@ -1766,7 +1766,7 @@ const BorderValue& LayoutTableSection::BorderAdjoiningStartCell(

: Style()->BorderEnd();

}

-const BorderValue& LayoutTableSection::BorderAdjoiningEndCell(

+BorderValue LayoutTableSection::BorderAdjoiningEndCell(

const LayoutTableCell* cell) const {

#if DCHECK_IS_ON()

DCHECK(cell->IsFirstOrLastCellInRow());