Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Side by Side Diff: third_party/WebKit/Source/core/layout/LayoutTableSection.cpp

Issue 2861773004: Move border-*-width out of BorderValue and store on SurroundData in ComputedStyle instead (Closed)
Patch Set: meade@'s suggestion Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1997 Martin Jones (mjones@kde.org) 2 * Copyright (C) 1997 Martin Jones (mjones@kde.org)
3 * (C) 1997 Torben Weis (weis@kde.org) 3 * (C) 1997 Torben Weis (weis@kde.org)
4 * (C) 1998 Waldo Bastian (bastian@kde.org) 4 * (C) 1998 Waldo Bastian (bastian@kde.org)
5 * (C) 1999 Lars Knoll (knoll@kde.org) 5 * (C) 1999 Lars Knoll (knoll@kde.org)
6 * (C) 1999 Antti Koivisto (koivisto@kde.org) 6 * (C) 1999 Antti Koivisto (koivisto@kde.org)
7 * Copyright (C) 2003, 2004, 2005, 2006, 2008, 2009, 2010, 2013 Apple Inc. 7 * Copyright (C) 2003, 2004, 2005, 2006, 2008, 2009, 2010, 2013 Apple Inc.
8 * All rights reserved. 8 * All rights reserved.
9 * Copyright (C) 2006 Alexey Proskuryakov (ap@nypop.com) 9 * Copyright (C) 2006 Alexey Proskuryakov (ap@nypop.com)
10 * 10 *
(...skipping 1739 matching lines...) Expand 10 before | Expand all | Expand 10 after
1750 for (unsigned c = result; c < n_cols; ++c) { 1750 for (unsigned c = result; c < n_cols; ++c) {
1751 const CellStruct& cell = CellAt(r, c); 1751 const CellStruct& cell = CellAt(r, c);
1752 if (cell.HasCells() || cell.in_col_span) 1752 if (cell.HasCells() || cell.in_col_span)
1753 result = c; 1753 result = c;
1754 } 1754 }
1755 } 1755 }
1756 1756
1757 return result + 1; 1757 return result + 1;
1758 } 1758 }
1759 1759
1760 const BorderValue& LayoutTableSection::BorderAdjoiningStartCell( 1760 BorderValue LayoutTableSection::BorderAdjoiningStartCell(
1761 const LayoutTableCell* cell) const { 1761 const LayoutTableCell* cell) const {
1762 #if DCHECK_IS_ON() 1762 #if DCHECK_IS_ON()
1763 DCHECK(cell->IsFirstOrLastCellInRow()); 1763 DCHECK(cell->IsFirstOrLastCellInRow());
1764 #endif 1764 #endif
1765 return HasSameDirectionAs(cell) ? Style()->BorderStart() 1765 return HasSameDirectionAs(cell) ? Style()->BorderStart()
1766 : Style()->BorderEnd(); 1766 : Style()->BorderEnd();
1767 } 1767 }
1768 1768
1769 const BorderValue& LayoutTableSection::BorderAdjoiningEndCell( 1769 BorderValue LayoutTableSection::BorderAdjoiningEndCell(
1770 const LayoutTableCell* cell) const { 1770 const LayoutTableCell* cell) const {
1771 #if DCHECK_IS_ON() 1771 #if DCHECK_IS_ON()
1772 DCHECK(cell->IsFirstOrLastCellInRow()); 1772 DCHECK(cell->IsFirstOrLastCellInRow());
1773 #endif 1773 #endif
1774 return HasSameDirectionAs(cell) ? Style()->BorderEnd() 1774 return HasSameDirectionAs(cell) ? Style()->BorderEnd()
1775 : Style()->BorderStart(); 1775 : Style()->BorderStart();
1776 } 1776 }
1777 1777
1778 const LayoutTableCell* LayoutTableSection::FirstRowCellAdjoiningTableStart() 1778 const LayoutTableCell* LayoutTableSection::FirstRowCellAdjoiningTableStart()
1779 const { 1779 const {
(...skipping 388 matching lines...) Expand 10 before | Expand all | Expand 10 after
2168 bool LayoutTableSection::PaintedOutputOfObjectHasNoEffectRegardlessOfSize() 2168 bool LayoutTableSection::PaintedOutputOfObjectHasNoEffectRegardlessOfSize()
2169 const { 2169 const {
2170 // LayoutTableSection paints background from columns. 2170 // LayoutTableSection paints background from columns.
2171 if (Table()->HasColElements()) 2171 if (Table()->HasColElements())
2172 return false; 2172 return false;
2173 return LayoutTableBoxComponent:: 2173 return LayoutTableBoxComponent::
2174 PaintedOutputOfObjectHasNoEffectRegardlessOfSize(); 2174 PaintedOutputOfObjectHasNoEffectRegardlessOfSize();
2175 } 2175 }
2176 2176
2177 } // namespace blink 2177 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutTableSection.h ('k') | third_party/WebKit/Source/core/style/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698