Issue 2861743002: blink: Remove last (non-bindings-tests) occurences of m_instVars.

Nico

The CQ bit was checked by thakis@chromium.org to run a CQ dry run

3 years, 7 months ago (2017-05-03 14:55:28 UTC) #1

Nico

thakis@chromium.org changed reviewers: + dcheng@chromium.org

3 years, 7 months ago (2017-05-03 14:55:35 UTC) #2

Nico

https://codereview.chromium.org/2861743002/diff/1/third_party/WebKit/Source/platform/wtf/Assertions.cpp File third_party/WebKit/Source/platform/wtf/Assertions.cpp (left): https://codereview.chromium.org/2861743002/diff/1/third_party/WebKit/Source/platform/wtf/Assertions.cpp#oldcode133 third_party/WebKit/Source/platform/wtf/Assertions.cpp:133: class FrameToNameScope { The last client of this was ...

3 years, 7 months ago (2017-05-03 14:55:36 UTC) #3

commit-bot: I haz the power

Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2861743002/1

3 years, 7 months ago (2017-05-03 14:55:44 UTC) #4

Nico

Huh, that regex doesn't find https://cs.chromium.org/chromium/src/third_party/WebKit/Source/platform/graphics/test/FakeGLES2Interface.h?type=cs&q=%5Cbm_+file:webkit+-file:bindings/tests/results&l=22 or https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/layout/GapRects.h?type=cs&q=%5Cbm_+file:webkit+-file:bindings/tests/results&l=33 for some reason? On Wed, May 3, ...

3 years, 7 months ago (2017-05-03 15:00:19 UTC) #5

Huh, that regex doesn't find
https://cs.chromium.org/chromium/src/third_party/WebKit/Source/platform/graph...
or
https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/layout/Ga...
for some reason?

On Wed, May 3, 2017 at 10:55 AM, <thakis@chromium.org> wrote:

> Reviewers: dcheng (OOO through May 2)
> CL: https://codereview.chromium.org/2861743002/
>
>
> https://codereview.chromium.org/2861743002/diff/1/third_
> party/WebKit/Source/platform/wtf/Assertions.cpp
> File third_party/WebKit/Source/platform/wtf/Assertions.cpp (left):
>
> https://codereview.chromium.org/2861743002/diff/1/third_
> party/WebKit/Source/platform/wtf/Assertions.cpp#oldcode133
> third_party/WebKit/Source/platform/wtf/Assertions.cpp:133: class
> FrameToNameScope {
> The last client of this was removed in
> https://codereview.chromium.org/2632643004/diff/80001/
> third_party/WebKit/Source/wtf/Assertions.cpp
>
> Description:
> blink: Remove last (non-comment, non-bindings-tests) occurences of
> m_instVars.
>
> See https://cs.chromium.org/search/?q=%5E%5B%5E/%5D*%5Cbm_
> +file:webkit&type=cs
>
> BUG=675877
>
> Affected files (+2, -36 lines):
> M third_party/WebKit/LayoutTests/compositing/child-
> transform-layer-rounding.html
> M third_party/WebKit/Source/bindings/core/v8/V8BindingDesign.md
> M third_party/WebKit/Source/platform/wtf/Assertions.cpp
>
>
> Index: third_party/WebKit/LayoutTests/compositing/child-
> transform-layer-rounding.html
> diff --git
a/third_party/WebKit/LayoutTests/compositing/child-transform-layer-rounding.html
> b/third_party/WebKit/LayoutTests/compositing/child-
> transform-layer-rounding.html
> index c6cb3797e602f591b58abffb19faf43f072be7c1..
> 1f8bf4fff29b0036dab0f458ae7be7b7f24f0a76 100644
> --- a/third_party/WebKit/LayoutTests/compositing/child-
> transform-layer-rounding.html
> +++ b/third_party/WebKit/LayoutTests/compositing/child-
> transform-layer-rounding.html
> @@ -1,7 +1,7 @@
> <!DOCTYPE HTML>
> <!--
> This test creates a situation where the child transform layer's position
> - needs to take into account the rounding that is applied to
> m_graphicsLayer.
> + needs to take into account the rounding that is applied to
> graphics_layer_.
> -->
> <style>
> #animDiv {
> Index: third_party/WebKit/Source/bindings/core/v8/V8BindingDesign.md
> diff --git a/third_party/WebKit/Source/bindings/core/v8/V8BindingDesign.md
> b/third_party/WebKit/Source/bindings/core/v8/V8BindingDesign.md
> index b4e8d3370c5a4a00e0ddf1be40a2ad084aa6e75f..
> 451055b6e5fe64e3bcc2a8d2fd647bee2fe5c6b6 100644
> --- a/third_party/WebKit/Source/bindings/core/v8/V8BindingDesign.md
> +++ b/third_party/WebKit/Source/bindings/core/v8/V8BindingDesign.md
> @@ -225,7 +225,7 @@ that stores a mapping from the C++ DOM objects to the
> DOM wrappers in that world
>
> As a result, we have multiple DOM wrapper storages in one isolate.
> The mapping of the main world is written in `ScriptWrappable`.
> -If `ScriptWrappable::m_mainWorldWrapper` has a non-empty value, it is a
> DOM
> +If `ScriptWrappable::main_world_wrapper_` has a non-empty value, it is a
> DOM
> wrapper of the C++ DOM object of the main world.
> The mapping of other worlds are written in `DOMWrapperMap`.
>
> Index: third_party/WebKit/Source/platform/wtf/Assertions.cpp
> diff --git a/third_party/WebKit/Source/platform/wtf/Assertions.cpp
> b/third_party/WebKit/Source/platform/wtf/Assertions.cpp
> index 25f7a8dc62f905965e2ff65dc97c0d1e3e37c2cc..
> 58785d66aed2de1c87289861af57c075c7396b03 100644
> --- a/third_party/WebKit/Source/platform/wtf/Assertions.cpp
> +++ b/third_party/WebKit/Source/platform/wtf/Assertions.cpp
> @@ -128,40 +128,6 @@ static void vprintf_stderr_with_trailing_newline(const
> char* format,
> #pragma GCC diagnostic pop
> #endif
>
> -namespace {
> -
> -class FrameToNameScope {
> - public:
> - explicit FrameToNameScope(void*);
> - ~FrameToNameScope();
> - const char* nullableName() { return m_name; }
> -
> - private:
> - const char* m_name;
> - char* m_cxaDemangled;
> -};
> -
> -FrameToNameScope::FrameToNameScope(void* addr) : m_name(0),
> m_cxaDemangled(0) {
> -#if OS(MACOSX) || (OS(LINUX) && !defined(__UCLIBC__))
> - Dl_info info;
> - if (!dladdr(addr, &info) || !info.dli_sname)
> - return;
> - const char* mangledName = info.dli_sname;
> - if ((m_cxaDemangled = abi::__cxa_demangle(mangledName, 0, 0, 0)))
> - m_name = m_cxaDemangled;
> - else
> - m_name = mangledName;
> -#else
> - (void)addr;
> -#endif
> -}
> -
> -FrameToNameScope::~FrameToNameScope() {
> - free(m_cxaDemangled);
> -}
> -
> -} // anonymous namespace
> -
> #if !LOG_DISABLED
> namespace WTF {
>
>
>
>

-- 
You received this message because you are subscribed to the Google Groups "Blink
Reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.

Nico

Huh, that regex doesn't find https://cs.chromium.org/chromium/src/third_party/WebKit/Source/platform/graphics/test/FakeGLES2Interface.h?type=cs&q=%5Cbm_+file:webkit+-file:bindings/tests/results&l=22 or https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/layout/GapRects.h?type=cs&q=%5Cbm_+file:webkit+-file:bindings/tests/results&l=33 for some reason? On Wed, May 3, ...

3 years, 7 months ago (2017-05-03 15:00:20 UTC) #6

Huh, that regex doesn't find
https://cs.chromium.org/chromium/src/third_party/WebKit/Source/platform/graph...
or
https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/layout/Ga...
for some reason?

On Wed, May 3, 2017 at 10:55 AM, <thakis@chromium.org> wrote:

> Reviewers: dcheng (OOO through May 2)
> CL: https://codereview.chromium.org/2861743002/
>
>
> https://codereview.chromium.org/2861743002/diff/1/third_
> party/WebKit/Source/platform/wtf/Assertions.cpp
> File third_party/WebKit/Source/platform/wtf/Assertions.cpp (left):
>
> https://codereview.chromium.org/2861743002/diff/1/third_
> party/WebKit/Source/platform/wtf/Assertions.cpp#oldcode133
> third_party/WebKit/Source/platform/wtf/Assertions.cpp:133: class
> FrameToNameScope {
> The last client of this was removed in
> https://codereview.chromium.org/2632643004/diff/80001/
> third_party/WebKit/Source/wtf/Assertions.cpp
>
> Description:
> blink: Remove last (non-comment, non-bindings-tests) occurences of
> m_instVars.
>
> See https://cs.chromium.org/search/?q=%5E%5B%5E/%5D*%5Cbm_
> +file:webkit&type=cs
>
> BUG=675877
>
> Affected files (+2, -36 lines):
> M third_party/WebKit/LayoutTests/compositing/child-
> transform-layer-rounding.html
> M third_party/WebKit/Source/bindings/core/v8/V8BindingDesign.md
> M third_party/WebKit/Source/platform/wtf/Assertions.cpp
>
>
> Index: third_party/WebKit/LayoutTests/compositing/child-
> transform-layer-rounding.html
> diff --git
a/third_party/WebKit/LayoutTests/compositing/child-transform-layer-rounding.html
> b/third_party/WebKit/LayoutTests/compositing/child-
> transform-layer-rounding.html
> index c6cb3797e602f591b58abffb19faf43f072be7c1..
> 1f8bf4fff29b0036dab0f458ae7be7b7f24f0a76 100644
> --- a/third_party/WebKit/LayoutTests/compositing/child-
> transform-layer-rounding.html
> +++ b/third_party/WebKit/LayoutTests/compositing/child-
> transform-layer-rounding.html
> @@ -1,7 +1,7 @@
> <!DOCTYPE HTML>
> <!--
> This test creates a situation where the child transform layer's position
> - needs to take into account the rounding that is applied to
> m_graphicsLayer.
> + needs to take into account the rounding that is applied to
> graphics_layer_.
> -->
> <style>
> #animDiv {
> Index: third_party/WebKit/Source/bindings/core/v8/V8BindingDesign.md
> diff --git a/third_party/WebKit/Source/bindings/core/v8/V8BindingDesign.md
> b/third_party/WebKit/Source/bindings/core/v8/V8BindingDesign.md
> index b4e8d3370c5a4a00e0ddf1be40a2ad084aa6e75f..
> 451055b6e5fe64e3bcc2a8d2fd647bee2fe5c6b6 100644
> --- a/third_party/WebKit/Source/bindings/core/v8/V8BindingDesign.md
> +++ b/third_party/WebKit/Source/bindings/core/v8/V8BindingDesign.md
> @@ -225,7 +225,7 @@ that stores a mapping from the C++ DOM objects to the
> DOM wrappers in that world
>
> As a result, we have multiple DOM wrapper storages in one isolate.
> The mapping of the main world is written in `ScriptWrappable`.
> -If `ScriptWrappable::m_mainWorldWrapper` has a non-empty value, it is a
> DOM
> +If `ScriptWrappable::main_world_wrapper_` has a non-empty value, it is a
> DOM
> wrapper of the C++ DOM object of the main world.
> The mapping of other worlds are written in `DOMWrapperMap`.
>
> Index: third_party/WebKit/Source/platform/wtf/Assertions.cpp
> diff --git a/third_party/WebKit/Source/platform/wtf/Assertions.cpp
> b/third_party/WebKit/Source/platform/wtf/Assertions.cpp
> index 25f7a8dc62f905965e2ff65dc97c0d1e3e37c2cc..
> 58785d66aed2de1c87289861af57c075c7396b03 100644
> --- a/third_party/WebKit/Source/platform/wtf/Assertions.cpp
> +++ b/third_party/WebKit/Source/platform/wtf/Assertions.cpp
> @@ -128,40 +128,6 @@ static void vprintf_stderr_with_trailing_newline(const
> char* format,
> #pragma GCC diagnostic pop
> #endif
>
> -namespace {
> -
> -class FrameToNameScope {
> - public:
> - explicit FrameToNameScope(void*);
> - ~FrameToNameScope();
> - const char* nullableName() { return m_name; }
> -
> - private:
> - const char* m_name;
> - char* m_cxaDemangled;
> -};
> -
> -FrameToNameScope::FrameToNameScope(void* addr) : m_name(0),
> m_cxaDemangled(0) {
> -#if OS(MACOSX) || (OS(LINUX) && !defined(__UCLIBC__))
> - Dl_info info;
> - if (!dladdr(addr, &info) || !info.dli_sname)
> - return;
> - const char* mangledName = info.dli_sname;
> - if ((m_cxaDemangled = abi::__cxa_demangle(mangledName, 0, 0, 0)))
> - m_name = m_cxaDemangled;
> - else
> - m_name = mangledName;
> -#else
> - (void)addr;
> -#endif
> -}
> -
> -FrameToNameScope::~FrameToNameScope() {
> - free(m_cxaDemangled);
> -}
> -
> -} // anonymous namespace
> -
> #if !LOG_DISABLED
> namespace WTF {
>
>
>
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

Nico

Aha, this one does: https://cs.chromium.org/search/?q=%5E%5B%5E/%5D*%5Cbm_+file:webkit&all=1&type=cs Looks like there's quite a bunch of stuff left :-/ ...

3 years, 7 months ago (2017-05-03 15:01:00 UTC) #7

Aha, this one does:
https://cs.chromium.org/search/?q=%5E%5B%5E/%5D*%5Cbm_+file:webkit&all=1&type=cs

Looks like there's quite a bunch of stuff left :-/

On Wed, May 3, 2017 at 11:00 AM, Nico Weber <thakis@chromium.org> wrote:

> Huh, that regex doesn't find https://cs.chromium.org/
> chromium/src/third_party/WebKit/Source/platform/graphics/test/
> FakeGLES2Interface.h?type=cs&q=%5Cbm_+file:webkit+-file:
> bindings/tests/results&l=22 or https://cs.chromium.org/
> chromium/src/third_party/WebKit/Source/core/layout/
> GapRects.h?type=cs&q=%5Cbm_+file:webkit+-file:bindings/tests/results&l=33
> for some reason?
>
> On Wed, May 3, 2017 at 10:55 AM, <thakis@chromium.org> wrote:
>
>> Reviewers: dcheng (OOO through May 2)
>> CL: https://codereview.chromium.org/2861743002/
>>
>>
>> https://codereview.chromium.org/2861743002/diff/1/third_part
>> y/WebKit/Source/platform/wtf/Assertions.cpp
>> File third_party/WebKit/Source/platform/wtf/Assertions.cpp (left):
>>
>> https://codereview.chromium.org/2861743002/diff/1/third_part
>> y/WebKit/Source/platform/wtf/Assertions.cpp#oldcode133
>> third_party/WebKit/Source/platform/wtf/Assertions.cpp:133: class
>> FrameToNameScope {
>> The last client of this was removed in
>> https://codereview.chromium.org/2632643004/diff/80001/third_
>> party/WebKit/Source/wtf/Assertions.cpp
>>
>> Description:
>> blink: Remove last (non-comment, non-bindings-tests) occurences of
>> m_instVars.
>>
>> See https://cs.chromium.org/search/?q=%5E%5B%5E/%5D*%5Cbm_+file:
>> webkit&type=cs
>>
>> BUG=675877
>>
>> Affected files (+2, -36 lines):
>> M third_party/WebKit/LayoutTests/compositing/child-transform-
>> layer-rounding.html
>> M third_party/WebKit/Source/bindings/core/v8/V8BindingDesign.md
>> M third_party/WebKit/Source/platform/wtf/Assertions.cpp
>>
>>
>> Index: third_party/WebKit/LayoutTests/compositing/child-transform-
>> layer-rounding.html
>> diff --git
a/third_party/WebKit/LayoutTests/compositing/child-transform-layer-rounding.html
>> b/third_party/WebKit/LayoutTests/compositing/child-transform
>> -layer-rounding.html
>> index
c6cb3797e602f591b58abffb19faf43f072be7c1..1f8bf4fff29b0036dab0f458ae7be7b7f24f0a76
>> 100644
>> --- a/third_party/WebKit/LayoutTests/compositing/child-transform
>> -layer-rounding.html
>> +++ b/third_party/WebKit/LayoutTests/compositing/child-transform
>> -layer-rounding.html
>> @@ -1,7 +1,7 @@
>> <!DOCTYPE HTML>
>> <!--
>> This test creates a situation where the child transform layer's position
>> - needs to take into account the rounding that is applied to
>> m_graphicsLayer.
>> + needs to take into account the rounding that is applied to
>> graphics_layer_.
>> -->
>> <style>
>> #animDiv {
>> Index: third_party/WebKit/Source/bindings/core/v8/V8BindingDesign.md
>> diff --git a/third_party/WebKit/Source/bindings/core/v8/V8BindingDesign.md
>> b/third_party/WebKit/Source/bindings/core/v8/V8BindingDesign.md
>> index
b4e8d3370c5a4a00e0ddf1be40a2ad084aa6e75f..451055b6e5fe64e3bcc2a8d2fd647bee2fe5c6b6
>> 100644
>> --- a/third_party/WebKit/Source/bindings/core/v8/V8BindingDesign.md
>> +++ b/third_party/WebKit/Source/bindings/core/v8/V8BindingDesign.md
>> @@ -225,7 +225,7 @@ that stores a mapping from the C++ DOM objects to the
>> DOM wrappers in that world
>>
>> As a result, we have multiple DOM wrapper storages in one isolate.
>> The mapping of the main world is written in `ScriptWrappable`.
>> -If `ScriptWrappable::m_mainWorldWrapper` has a non-empty value, it is a
>> DOM
>> +If `ScriptWrappable::main_world_wrapper_` has a non-empty value, it is
>> a DOM
>> wrapper of the C++ DOM object of the main world.
>> The mapping of other worlds are written in `DOMWrapperMap`.
>>
>> Index: third_party/WebKit/Source/platform/wtf/Assertions.cpp
>> diff --git a/third_party/WebKit/Source/platform/wtf/Assertions.cpp
>> b/third_party/WebKit/Source/platform/wtf/Assertions.cpp
>> index
25f7a8dc62f905965e2ff65dc97c0d1e3e37c2cc..58785d66aed2de1c87289861af57c075c7396b03
>> 100644
>> --- a/third_party/WebKit/Source/platform/wtf/Assertions.cpp
>> +++ b/third_party/WebKit/Source/platform/wtf/Assertions.cpp
>> @@ -128,40 +128,6 @@ static void vprintf_stderr_with_trailing_newline(const
>> char* format,
>> #pragma GCC diagnostic pop
>> #endif
>>
>> -namespace {
>> -
>> -class FrameToNameScope {
>> - public:
>> - explicit FrameToNameScope(void*);
>> - ~FrameToNameScope();
>> - const char* nullableName() { return m_name; }
>> -
>> - private:
>> - const char* m_name;
>> - char* m_cxaDemangled;
>> -};
>> -
>> -FrameToNameScope::FrameToNameScope(void* addr) : m_name(0),
>> m_cxaDemangled(0) {
>> -#if OS(MACOSX) || (OS(LINUX) && !defined(__UCLIBC__))
>> - Dl_info info;
>> - if (!dladdr(addr, &info) || !info.dli_sname)
>> - return;
>> - const char* mangledName = info.dli_sname;
>> - if ((m_cxaDemangled = abi::__cxa_demangle(mangledName, 0, 0, 0)))
>> - m_name = m_cxaDemangled;
>> - else
>> - m_name = mangledName;
>> -#else
>> - (void)addr;
>> -#endif
>> -}
>> -
>> -FrameToNameScope::~FrameToNameScope() {
>> - free(m_cxaDemangled);
>> -}
>> -
>> -} // anonymous namespace
>> -
>> #if !LOG_DISABLED
>> namespace WTF {
>>
>>
>>
>>
>

-- 
You received this message because you are subscribed to the Google Groups "Blink
Reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.

Nico

Aha, this one does: https://cs.chromium.org/search/?q=%5E%5B%5E/%5D*%5Cbm_+file:webkit&all=1&type=cs Looks like there's quite a bunch of stuff left :-/ ...

3 years, 7 months ago (2017-05-03 15:01:00 UTC) #8

Aha, this one does:
https://cs.chromium.org/search/?q=%5E%5B%5E/%5D*%5Cbm_+file:webkit&all=1&type=cs

Looks like there's quite a bunch of stuff left :-/

On Wed, May 3, 2017 at 11:00 AM, Nico Weber <thakis@chromium.org> wrote:

> Huh, that regex doesn't find https://cs.chromium.org/
> chromium/src/third_party/WebKit/Source/platform/graphics/test/
> FakeGLES2Interface.h?type=cs&q=%5Cbm_+file:webkit+-file:
> bindings/tests/results&l=22 or https://cs.chromium.org/
> chromium/src/third_party/WebKit/Source/core/layout/
> GapRects.h?type=cs&q=%5Cbm_+file:webkit+-file:bindings/tests/results&l=33
> for some reason?
>
> On Wed, May 3, 2017 at 10:55 AM, <thakis@chromium.org> wrote:
>
>> Reviewers: dcheng (OOO through May 2)
>> CL: https://codereview.chromium.org/2861743002/
>>
>>
>> https://codereview.chromium.org/2861743002/diff/1/third_part
>> y/WebKit/Source/platform/wtf/Assertions.cpp
>> File third_party/WebKit/Source/platform/wtf/Assertions.cpp (left):
>>
>> https://codereview.chromium.org/2861743002/diff/1/third_part
>> y/WebKit/Source/platform/wtf/Assertions.cpp#oldcode133
>> third_party/WebKit/Source/platform/wtf/Assertions.cpp:133: class
>> FrameToNameScope {
>> The last client of this was removed in
>> https://codereview.chromium.org/2632643004/diff/80001/third_
>> party/WebKit/Source/wtf/Assertions.cpp
>>
>> Description:
>> blink: Remove last (non-comment, non-bindings-tests) occurences of
>> m_instVars.
>>
>> See https://cs.chromium.org/search/?q=%5E%5B%5E/%5D*%5Cbm_+file:
>> webkit&type=cs
>>
>> BUG=675877
>>
>> Affected files (+2, -36 lines):
>> M third_party/WebKit/LayoutTests/compositing/child-transform-
>> layer-rounding.html
>> M third_party/WebKit/Source/bindings/core/v8/V8BindingDesign.md
>> M third_party/WebKit/Source/platform/wtf/Assertions.cpp
>>
>>
>> Index: third_party/WebKit/LayoutTests/compositing/child-transform-
>> layer-rounding.html
>> diff --git
a/third_party/WebKit/LayoutTests/compositing/child-transform-layer-rounding.html
>> b/third_party/WebKit/LayoutTests/compositing/child-transform
>> -layer-rounding.html
>> index
c6cb3797e602f591b58abffb19faf43f072be7c1..1f8bf4fff29b0036dab0f458ae7be7b7f24f0a76
>> 100644
>> --- a/third_party/WebKit/LayoutTests/compositing/child-transform
>> -layer-rounding.html
>> +++ b/third_party/WebKit/LayoutTests/compositing/child-transform
>> -layer-rounding.html
>> @@ -1,7 +1,7 @@
>> <!DOCTYPE HTML>
>> <!--
>> This test creates a situation where the child transform layer's position
>> - needs to take into account the rounding that is applied to
>> m_graphicsLayer.
>> + needs to take into account the rounding that is applied to
>> graphics_layer_.
>> -->
>> <style>
>> #animDiv {
>> Index: third_party/WebKit/Source/bindings/core/v8/V8BindingDesign.md
>> diff --git a/third_party/WebKit/Source/bindings/core/v8/V8BindingDesign.md
>> b/third_party/WebKit/Source/bindings/core/v8/V8BindingDesign.md
>> index
b4e8d3370c5a4a00e0ddf1be40a2ad084aa6e75f..451055b6e5fe64e3bcc2a8d2fd647bee2fe5c6b6
>> 100644
>> --- a/third_party/WebKit/Source/bindings/core/v8/V8BindingDesign.md
>> +++ b/third_party/WebKit/Source/bindings/core/v8/V8BindingDesign.md
>> @@ -225,7 +225,7 @@ that stores a mapping from the C++ DOM objects to the
>> DOM wrappers in that world
>>
>> As a result, we have multiple DOM wrapper storages in one isolate.
>> The mapping of the main world is written in `ScriptWrappable`.
>> -If `ScriptWrappable::m_mainWorldWrapper` has a non-empty value, it is a
>> DOM
>> +If `ScriptWrappable::main_world_wrapper_` has a non-empty value, it is
>> a DOM
>> wrapper of the C++ DOM object of the main world.
>> The mapping of other worlds are written in `DOMWrapperMap`.
>>
>> Index: third_party/WebKit/Source/platform/wtf/Assertions.cpp
>> diff --git a/third_party/WebKit/Source/platform/wtf/Assertions.cpp
>> b/third_party/WebKit/Source/platform/wtf/Assertions.cpp
>> index
25f7a8dc62f905965e2ff65dc97c0d1e3e37c2cc..58785d66aed2de1c87289861af57c075c7396b03
>> 100644
>> --- a/third_party/WebKit/Source/platform/wtf/Assertions.cpp
>> +++ b/third_party/WebKit/Source/platform/wtf/Assertions.cpp
>> @@ -128,40 +128,6 @@ static void vprintf_stderr_with_trailing_newline(const
>> char* format,
>> #pragma GCC diagnostic pop
>> #endif
>>
>> -namespace {
>> -
>> -class FrameToNameScope {
>> - public:
>> - explicit FrameToNameScope(void*);
>> - ~FrameToNameScope();
>> - const char* nullableName() { return m_name; }
>> -
>> - private:
>> - const char* m_name;
>> - char* m_cxaDemangled;
>> -};
>> -
>> -FrameToNameScope::FrameToNameScope(void* addr) : m_name(0),
>> m_cxaDemangled(0) {
>> -#if OS(MACOSX) || (OS(LINUX) && !defined(__UCLIBC__))
>> - Dl_info info;
>> - if (!dladdr(addr, &info) || !info.dli_sname)
>> - return;
>> - const char* mangledName = info.dli_sname;
>> - if ((m_cxaDemangled = abi::__cxa_demangle(mangledName, 0, 0, 0)))
>> - m_name = m_cxaDemangled;
>> - else
>> - m_name = mangledName;
>> -#else
>> - (void)addr;
>> -#endif
>> -}
>> -
>> -FrameToNameScope::~FrameToNameScope() {
>> - free(m_cxaDemangled);
>> -}
>> -
>> -} // anonymous namespace
>> -
>> #if !LOG_DISABLED
>> namespace WTF {
>>
>>
>>
>>
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

commit-bot: I haz the power

The CQ bit was unchecked by commit-bot@chromium.org

3 years, 7 months ago (2017-05-03 16:25:41 UTC) #9

commit-bot: I haz the power

Dry run: This issue passed the CQ dry run.

3 years, 7 months ago (2017-05-03 16:25:42 UTC) #10

Nico

Description was changed from ========== blink: Remove last (non-comment, non-bindings-tests) occurences of m_instVars. See https://cs.chromium.org/search/?q=%5E%5B%5E/%5D*%5Cbm_+file:webkit&type=cs ...

3 years, 7 months ago (2017-05-03 17:00:44 UTC) #12

commit-bot: I haz the power

CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2861743002/1

3 years, 7 months ago (2017-05-03 17:01:29 UTC) #14

commit-bot: I haz the power

CQ is committing da patch. Bot data: {"patchset_id": 1, "attempt_start_ts": 1493830853303880, "parent_rev": "5b8e924e113522f1ea8e5ced2e511675b543f460", "commit_rev": "1fcc6d6a6ac58eabe2c77a804e3220318a0dc1f3"}

3 years, 7 months ago (2017-05-03 17:09:01 UTC) #15

commit-bot: I haz the power

Description was changed from ========== blink: Remove some (non-comment, non-bindings-tests) occurences of m_instVars. See https://cs.chromium.org/search/?q=%5E%5B%5E/%5D*%5Cbm_+file:webkit&type=cs ...

3 years, 7 months ago (2017-05-03 17:09:15 UTC) #16

commit-bot: I haz the power

3 years, 7 months ago (2017-05-03 17:09:16 UTC) #17

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/1fcc6d6a6ac58eabe2c77a804e32...

Issue 2861743002: blink: Remove last (non-bindings-tests) occurences of m_instVars. (Closed)

Description

Patch Set 1 #

Messages