Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issue 2861723002: Smoke test for login screen apps (Closed)

Created:
3 years, 7 months ago by emaxx
Modified:
3 years, 7 months ago
CC:
chromium-reviews, oshima+watch_chromium.org, davemoore+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Smoke test for login screen apps Add a minimum test that only enables the login screen apps functionality via the command line flag. The purpose of this test is to investigate whether just specifying this command line flag may lead to tests being timed out. The plan is to remove this test once this investigation finishes, in favor of more complete end-to-end tests. BUG=626343 Review-Url: https://codereview.chromium.org/2861723002 Cr-Commit-Position: refs/heads/master@{#469330} Committed: https://chromium.googlesource.com/chromium/src/+/d54208b027fb61e6123a978e4e6145250fc18964

Patch Set 1 #

Patch Set 2 : Rename test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -0 lines) Patch
A chrome/browser/chromeos/policy/signin_profile_apps_policy_browsertest.cc View 1 1 chunk +50 lines, -0 lines 0 comments Download
M chrome/test/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 22 (17 generated)
emaxx
Drew, PTAL. Do you think it's reasonable to land this smoke test now, for being ...
3 years, 7 months ago (2017-05-03 12:59:29 UTC) #4
emaxx
Friendly ping.
3 years, 7 months ago (2017-05-04 14:22:16 UTC) #15
Andrew T Wilson (Slow)
lgtm
3 years, 7 months ago (2017-05-04 14:40:48 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2861723002/20001
3 years, 7 months ago (2017-05-04 14:42:09 UTC) #19
commit-bot: I haz the power
3 years, 7 months ago (2017-05-04 14:45:41 UTC) #22
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/d54208b027fb61e6123a978e4e61...

Powered by Google App Engine
This is Rietveld 408576698