Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1221)

Unified Diff: chrome/browser/resources/print_preview/settings/scaling_settings.js

Issue 2861713004: Print Preview: Fix compile errors in settings/ directory (Closed)
Patch Set: Address comments and fix remaining lint errors Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/print_preview/settings/scaling_settings.js
diff --git a/chrome/browser/resources/print_preview/settings/scaling_settings.js b/chrome/browser/resources/print_preview/settings/scaling_settings.js
index 3857127b1e19832ee6803a57a980772c3946abaf..40ce29a7d80d5e1cf3d0be7ff969c87ee282e821 100644
--- a/chrome/browser/resources/print_preview/settings/scaling_settings.js
+++ b/chrome/browser/resources/print_preview/settings/scaling_settings.js
@@ -7,9 +7,9 @@ cr.define('print_preview', function() {
/**
* Component that renders the scaling settings UI.
- * @param {!print_preview.ticket_items.scalingTicketItem} scalingTicketItem
+ * @param {!print_preview.ticket_items.Scaling} scalingTicketItem
* Used to read and write the scaling value.
- * @param {!print_preview.ticket_items.fitToPageticketItem}
+ * @param {!print_preview.ticket_items.FitToPage}
* fitToPageTicketItem Used to read the fit to page value.
* @constructor
* @extends {print_preview.SettingsSection}
@@ -53,7 +53,7 @@ cr.define('print_preview', function() {
*/
this.inputField_ = null;
- };
+ }
/**
* Delay in milliseconds before processing the textfield.
@@ -85,7 +85,7 @@ cr.define('print_preview', function() {
/** @override */
enterDocument: function() {
- this.inputField_ = this.getChildElement('input.user-value');
+ this.inputField_ = assert(this.getChildElement('input.user-value'));
print_preview.SettingsSection.prototype.enterDocument.call(this);
this.tracker.add(
this.inputField_,
@@ -115,7 +115,7 @@ cr.define('print_preview', function() {
*/
isFitToPageSelected: function() {
return this.fitToPageTicketItem_.isCapabilityAvailable() &&
- this.fitToPageTicketItem_.getValue();
+ !!this.fitToPageTicketItem_.getValue();
},
/**

Powered by Google App Engine
This is Rietveld 408576698