Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(473)

Unified Diff: chrome/browser/resources/print_preview/settings/page_settings.js

Issue 2861713004: Print Preview: Fix compile errors in settings/ directory (Closed)
Patch Set: Address comments and fix remaining lint errors Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/print_preview/settings/page_settings.js
diff --git a/chrome/browser/resources/print_preview/settings/page_settings.js b/chrome/browser/resources/print_preview/settings/page_settings.js
index ef1cf1794a09ff89e38ead9420f6c66dddf606ab..e5ddd6a489937a1ffa91f342e1f134877e3e8fec 100644
--- a/chrome/browser/resources/print_preview/settings/page_settings.js
+++ b/chrome/browser/resources/print_preview/settings/page_settings.js
@@ -57,7 +57,7 @@ cr.define('print_preview', function() {
* @private
*/
this.customHintEl_ = null;
- };
+ }
/**
* CSS classes used by the page settings.
@@ -101,18 +101,29 @@ cr.define('print_preview', function() {
/** @override */
enterDocument: function() {
print_preview.SettingsSection.prototype.enterDocument.call(this);
+ var customInput = assert(this.customInput_);
this.tracker.add(
- this.allRadio_, 'click', this.onAllRadioClick_.bind(this));
+ assert(this.allRadio_), 'click', this.onAllRadioClick_.bind(this));
this.tracker.add(
- this.customRadio_, 'click', this.onCustomRadioClick_.bind(this));
+ assert(this.customRadio_),
+ 'click',
+ this.onCustomRadioClick_.bind(this));
this.tracker.add(
- this.customInput_, 'blur', this.onCustomInputBlur_.bind(this));
+ customInput,
+ 'blur',
+ this.onCustomInputBlur_.bind(this));
this.tracker.add(
- this.customInput_, 'focus', this.onCustomInputFocus_.bind(this));
+ customInput,
+ 'focus',
+ this.onCustomInputFocus_.bind(this));
this.tracker.add(
- this.customInput_, 'keydown', this.onCustomInputKeyDown_.bind(this));
+ customInput,
+ 'keydown',
+ this.onCustomInputKeyDown_.bind(this));
this.tracker.add(
- this.customInput_, 'input', this.onCustomInputChange_.bind(this));
+ customInput,
+ 'input',
+ this.onCustomInputChange_.bind(this));
this.tracker.add(
this.pageRangeTicketItem_,
print_preview.ticket_items.TicketItem.EventType.CHANGE,

Powered by Google App Engine
This is Rietveld 408576698