Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(374)

Issue 2861713003: cc: Remove SurfaceDependencies type (Closed)

Created:
3 years, 7 months ago by Fady Samuel
Modified:
3 years, 7 months ago
Reviewers:
vmpstr
CC:
chromium-reviews, cc-bugs_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Remove SurfaceDependencies type SurfaceDependencies is a type alias that was introduced in PendingFrameObserver but is not used consistently making understanding types more difficult. This CL simplify removes the type alias. BUG=none CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2861713003 Cr-Commit-Position: refs/heads/master@{#469476} Committed: https://chromium.googlesource.com/chromium/src/+/4d71e46c292ec537736a813991cfb3b641cacf65

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -16 lines) Patch
M cc/surfaces/pending_frame_observer.h View 2 chunks +2 lines, -4 lines 0 comments Download
M cc/surfaces/surface.h View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/surfaces/surface.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/surfaces/surface_dependency_tracker.h View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/surfaces/surface_dependency_tracker.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/surfaces/surface_factory.h View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/surfaces/surface_factory.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
Fady Samuel
PTAL
3 years, 7 months ago (2017-05-03 17:09:58 UTC) #3
Fady Samuel
3 years, 7 months ago (2017-05-04 03:16:56 UTC) #8
vmpstr
lgtm
3 years, 7 months ago (2017-05-04 20:15:31 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2861713003/1
3 years, 7 months ago (2017-05-04 20:21:53 UTC) #11
commit-bot: I haz the power
3 years, 7 months ago (2017-05-04 21:23:37 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/4d71e46c292ec537736a813991cf...

Powered by Google App Engine
This is Rietveld 408576698