Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 2861673009: android: Remove ChildProcessServiceImpl.sContext (Closed)

Created:
3 years, 7 months ago by boliu
Modified:
3 years, 7 months ago
Reviewers:
agrieve
CC:
chromium-reviews, jam, darin-cc_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

android: Remove ChildProcessServiceImpl.sContext getContext is never called so the only use case left is checking that create is not called more than once in this process. It's an AutomicReference, but is not used atomically (ie it's not really calling compareAndSet). So it can just replace it with a bool instead. BUG=689758 Review-Url: https://codereview.chromium.org/2861673009 Cr-Commit-Position: refs/heads/master@{#469832} Committed: https://chromium.googlesource.com/chromium/src/+/56de014ae2e5f80d5a009401d8d513314b3b5a6d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -8 lines) Patch
M content/public/android/java/src/org/chromium/content/app/ChildProcessServiceImpl.java View 4 chunks +6 lines, -8 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
boliu
ptal, minor clean up
3 years, 7 months ago (2017-05-05 17:39:22 UTC) #2
agrieve
lgtm
3 years, 7 months ago (2017-05-05 17:54:29 UTC) #5
boliu
3 years, 7 months ago (2017-05-05 17:56:34 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2861673009/1
3 years, 7 months ago (2017-05-05 17:57:08 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/286932)
3 years, 7 months ago (2017-05-05 21:55:00 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2861673009/1
3 years, 7 months ago (2017-05-05 23:03:43 UTC) #13
commit-bot: I haz the power
3 years, 7 months ago (2017-05-06 00:50:05 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/56de014ae2e5f80d5a009401d8d5...

Powered by Google App Engine
This is Rietveld 408576698