Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 2861653003: [Chromecast] Log summary of keystatuseschange event (Closed)

Created:
3 years, 7 months ago by halliwell
Modified:
3 years, 7 months ago
Reviewers:
lcwu1, slan, yucliu1
CC:
chromium-reviews, eme-reviews_chromium.org, lcwu+watch_chromium.org, feature-media-reviews_chromium.org, halliwell+watch_chromium.org, alokp+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Chromecast] Log summary of keystatuseschange event Help diagnose bugs from non-usable keys more quickly. BUG=internal b/37379047 Review-Url: https://codereview.chromium.org/2861653003 Cr-Commit-Position: refs/heads/master@{#469247} Committed: https://chromium.googlesource.com/chromium/src/+/0e21b049f7e29614a89c13fed4fcf40cc74d937d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -0 lines) Patch
M chromecast/media/cdm/cast_cdm.cc View 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
halliwell
3 years, 7 months ago (2017-05-04 00:52:31 UTC) #3
yucliu1
On 2017/05/04 00:52:31, halliwell wrote: lgtm
3 years, 7 months ago (2017-05-04 01:22:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2861653003/1
3 years, 7 months ago (2017-05-04 02:05:54 UTC) #6
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the ...
3 years, 7 months ago (2017-05-04 02:05:57 UTC) #8
halliwell
+slan
3 years, 7 months ago (2017-05-04 02:06:35 UTC) #10
lcwu1
On 2017/05/04 02:06:35, halliwell wrote: > +slan rs lgtm
3 years, 7 months ago (2017-05-04 02:08:11 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2861653003/1
3 years, 7 months ago (2017-05-04 02:09:24 UTC) #13
commit-bot: I haz the power
3 years, 7 months ago (2017-05-04 02:20:51 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/0e21b049f7e29614a89c13fed4fc...

Powered by Google App Engine
This is Rietveld 408576698