Implements CSSPropertyAPI for the font-feature-settings property.

Implements CSSPropertyAPI for the font-feature-settings property.

A part of Project Ribbon, separating the parsing logic for CSS
properties from the parser into an API. This patch removes
CSSPropertyFontFeatureSettings from the switch statement in
parseSingleValue, and calls the API instead.

This patch:
- Adds CSSPropertyAPIFontFeatureSettings.cpp to the BUILD.gn file.
- Adds parseSingleValue to font-feature-settings in CSSProperties.json5 so that it will be added to the generated files for the api.
- Moves the parsing logic for font-feature-settings from CSSPropertyParser.cpp to
  CSSPropertyAPIFontFeatureSettings.cpp, which implements CSSPropertyAPI.h.

Diff: https://gist.github.com/jm318/db6da170e28cb7fefa0056a364f164f0/revisions

BUG=668012
Review-Url: https://codereview.chromium.org/2861633002
Cr-Commit-Position: refs/heads/master@{#469282}
Committed: https://chromium.googlesource.com/chromium/src/+/b0f43286afa116cc6ac6160cbf9cec199ba56ee3

[Jia, 2017-05-03 05:45:04]

Description was changed from

==========
Implements CSSPropertyAPI for the font-feature-settings property.

A part of Project Ribbon, separating the parsing logic for CSS
properties from the parser into an API. This patch removes
CSSPropertyFontFeatureSettings from the switch statement in
parseSingleValue, and calls the API instead.

A function pointer to the parseSingleValue function from the API for the
font-feature-settings property is stored in a CSSPropertyDescriptor, and is
called from CSSPropertyParser.

This patch:
- Adds CSSPropertyAPIFontFeatureSettings.cpp to the BUILD.gn file.
- Adds api_class flag to CSSProperties.in, which indicates that
  CSSPropertyAPIFontFeatureSettings.h is generated.
- Moves the parsing logic for font-feature-settings from CSSPropertyParser.cpp
to
  CSSPropertyAPIFontFeatureSettings.cpp, which implements CSSPropertyAPI.h.

BUG=668012
==========

to

==========
Implements CSSPropertyAPI for the font-feature-settings property.

A part of Project Ribbon, separating the parsing logic for CSS
properties from the parser into an API. This patch removes
CSSPropertyFontFeatureSettings from the switch statement in
parseSingleValue, and calls the API instead.

This patch:
- Adds CSSPropertyAPIFontFeatureSettings.cpp to the BUILD.gn file.
- Adds parseSingleValue to counter-reset in CSSProperties.json5 so that it will
be added to the generated files for the api.
- Moves the parsing logic for font-feature-settings from CSSPropertyParser.cpp
to
  CSSPropertyAPIFontFeatureSettings.cpp, which implements CSSPropertyAPI.h.

BUG=668012
==========

[Jia, 2017-05-03 05:49:55]

Description was changed from

==========
Implements CSSPropertyAPI for the font-feature-settings property.

A part of Project Ribbon, separating the parsing logic for CSS
properties from the parser into an API. This patch removes
CSSPropertyFontFeatureSettings from the switch statement in
parseSingleValue, and calls the API instead.

This patch:
- Adds CSSPropertyAPIFontFeatureSettings.cpp to the BUILD.gn file.
- Adds parseSingleValue to counter-reset in CSSProperties.json5 so that it will
be added to the generated files for the api.
- Moves the parsing logic for font-feature-settings from CSSPropertyParser.cpp
to
  CSSPropertyAPIFontFeatureSettings.cpp, which implements CSSPropertyAPI.h.

BUG=668012
==========

to

==========
Implements CSSPropertyAPI for the font-feature-settings property.

A part of Project Ribbon, separating the parsing logic for CSS
properties from the parser into an API. This patch removes
CSSPropertyFontFeatureSettings from the switch statement in
parseSingleValue, and calls the API instead.

This patch:
- Adds CSSPropertyAPIFontFeatureSettings.cpp to the BUILD.gn file.
- Adds parseSingleValue to font-feature-settings in CSSProperties.json5 so that
it will be added to the generated files for the api.
- Moves the parsing logic for font-feature-settings from CSSPropertyParser.cpp
to
  CSSPropertyAPIFontFeatureSettings.cpp, which implements CSSPropertyAPI.h.

BUG=668012
==========

[Jia, 2017-05-03 05:50:22]

The CQ bit was checked by jiameng@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-03 05:50:32]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-03 07:46:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-03 07:46:32]

Dry run: This issue passed the CQ dry run.

[Jia, 2017-05-03 08:27:38]

jiameng@chromium.org changed reviewers:
+ bugsnash@chromium.org, meade@chromium.org

[Bugs Nash, 2017-05-04 03:25:30]

lgtm with include removal

congrats on your first stylimations patch!!

https://codereview.chromium.org/2861633002/diff/1/third_party/WebKit/Source/c...
File
third_party/WebKit/Source/core/css/properties/CSSPropertyAPIFontFeatureSettings.cpp
(right):

https://codereview.chromium.org/2861633002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/css/properties/CSSPropertyAPIFontFeatureSettings.cpp:7:
#include "core/css/parser/CSSParserContext.h"
this doesn't need to be included, can be forward declared instead

[Jia, 2017-05-04 04:14:48]

Thanks Bugs! PTAL.

https://codereview.chromium.org/2861633002/diff/1/third_party/WebKit/Source/c...
File
third_party/WebKit/Source/core/css/properties/CSSPropertyAPIFontFeatureSettings.cpp
(right):

https://codereview.chromium.org/2861633002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/css/properties/CSSPropertyAPIFontFeatureSettings.cpp:7:
#include "core/css/parser/CSSParserContext.h"
On 2017/05/04 03:25:30, Bugs Nash wrote:
> this doesn't need to be included, can be forward declared instead

Done.

[Jia, 2017-05-04 04:14:56]

The CQ bit was checked by jiameng@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-04 04:15:09]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Jia, 2017-05-04 04:39:18]

Description was changed from

==========
Implements CSSPropertyAPI for the font-feature-settings property.

A part of Project Ribbon, separating the parsing logic for CSS
properties from the parser into an API. This patch removes
CSSPropertyFontFeatureSettings from the switch statement in
parseSingleValue, and calls the API instead.

This patch:
- Adds CSSPropertyAPIFontFeatureSettings.cpp to the BUILD.gn file.
- Adds parseSingleValue to font-feature-settings in CSSProperties.json5 so that
it will be added to the generated files for the api.
- Moves the parsing logic for font-feature-settings from CSSPropertyParser.cpp
to
  CSSPropertyAPIFontFeatureSettings.cpp, which implements CSSPropertyAPI.h.

BUG=668012
==========

to

==========
Implements CSSPropertyAPI for the font-feature-settings property.

A part of Project Ribbon, separating the parsing logic for CSS
properties from the parser into an API. This patch removes
CSSPropertyFontFeatureSettings from the switch statement in
parseSingleValue, and calls the API instead.

This patch:
- Adds CSSPropertyAPIFontFeatureSettings.cpp to the BUILD.gn file.
- Adds parseSingleValue to font-feature-settings in CSSProperties.json5 so that
it will be added to the generated files for the api.
- Moves the parsing logic for font-feature-settings from CSSPropertyParser.cpp
to
  CSSPropertyAPIFontFeatureSettings.cpp, which implements CSSPropertyAPI.h.

Diff:https://gist.github.com/jm318/db6da170e28cb7fefa0056a364f164f0/revisions

BUG=668012
==========

[Jia, 2017-05-04 04:39:35]

Description was changed from

==========
Implements CSSPropertyAPI for the font-feature-settings property.

A part of Project Ribbon, separating the parsing logic for CSS
properties from the parser into an API. This patch removes
CSSPropertyFontFeatureSettings from the switch statement in
parseSingleValue, and calls the API instead.

This patch:
- Adds CSSPropertyAPIFontFeatureSettings.cpp to the BUILD.gn file.
- Adds parseSingleValue to font-feature-settings in CSSProperties.json5 so that
it will be added to the generated files for the api.
- Moves the parsing logic for font-feature-settings from CSSPropertyParser.cpp
to
  CSSPropertyAPIFontFeatureSettings.cpp, which implements CSSPropertyAPI.h.

Diff:https://gist.github.com/jm318/db6da170e28cb7fefa0056a364f164f0/revisions

BUG=668012
==========

to

==========
Implements CSSPropertyAPI for the font-feature-settings property.

A part of Project Ribbon, separating the parsing logic for CSS
properties from the parser into an API. This patch removes
CSSPropertyFontFeatureSettings from the switch statement in
parseSingleValue, and calls the API instead.

This patch:
- Adds CSSPropertyAPIFontFeatureSettings.cpp to the BUILD.gn file.
- Adds parseSingleValue to font-feature-settings in CSSProperties.json5 so that
it will be added to the generated files for the api.
- Moves the parsing logic for font-feature-settings from CSSPropertyParser.cpp
to
  CSSPropertyAPIFontFeatureSettings.cpp, which implements CSSPropertyAPI.h.

Diff: https://gist.github.com/jm318/db6da170e28cb7fefa0056a364f164f0/revisions

BUG=668012
==========

[Jia, 2017-05-04 04:40:33]

Added diff of generated files.

[meade_UTC10, 2017-05-04 04:45:07]

lgtm \o/ Nice job on getting the first CL up so quickly!

[Jia, 2017-05-04 04:49:33]

On 2017/05/04 04:45:07, meade_UTC10 wrote:
> lgtm \o/ Nice job on getting the first CL up so quickly!

Thanks Eddy! :)

[commit-bot: I haz the power, 2017-05-04 05:55:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-04 05:55:05]

Dry run: This issue passed the CQ dry run.

[Jia, 2017-05-04 05:59:20]

The CQ bit was checked by jiameng@chromium.org

[Jia, 2017-05-04 05:59:21]

The patchset sent to the CQ was uploaded after l-g-t-m from
bugsnash@chromium.org
Link to the patchset: https://codereview.chromium.org/2861633002/#ps20001
(title: "Replaced include by forward declaration.")

[commit-bot: I haz the power, 2017-05-04 05:59:36]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-04 06:03:32]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1493877560550820,
"parent_rev": "a32022824f01698ab161130a96c2832a8226bb46", "commit_rev":
"b0f43286afa116cc6ac6160cbf9cec199ba56ee3"}

[commit-bot: I haz the power, 2017-05-04 06:03:43]

Description was changed from

==========
Implements CSSPropertyAPI for the font-feature-settings property.

A part of Project Ribbon, separating the parsing logic for CSS
properties from the parser into an API. This patch removes
CSSPropertyFontFeatureSettings from the switch statement in
parseSingleValue, and calls the API instead.

This patch:
- Adds CSSPropertyAPIFontFeatureSettings.cpp to the BUILD.gn file.
- Adds parseSingleValue to font-feature-settings in CSSProperties.json5 so that
it will be added to the generated files for the api.
- Moves the parsing logic for font-feature-settings from CSSPropertyParser.cpp
to
  CSSPropertyAPIFontFeatureSettings.cpp, which implements CSSPropertyAPI.h.

Diff: https://gist.github.com/jm318/db6da170e28cb7fefa0056a364f164f0/revisions

BUG=668012
==========

to

==========
Implements CSSPropertyAPI for the font-feature-settings property.

A part of Project Ribbon, separating the parsing logic for CSS
properties from the parser into an API. This patch removes
CSSPropertyFontFeatureSettings from the switch statement in
parseSingleValue, and calls the API instead.

This patch:
- Adds CSSPropertyAPIFontFeatureSettings.cpp to the BUILD.gn file.
- Adds parseSingleValue to font-feature-settings in CSSProperties.json5 so that
it will be added to the generated files for the api.
- Moves the parsing logic for font-feature-settings from CSSPropertyParser.cpp
to
  CSSPropertyAPIFontFeatureSettings.cpp, which implements CSSPropertyAPI.h.

Diff: https://gist.github.com/jm318/db6da170e28cb7fefa0056a364f164f0/revisions

BUG=668012

Review-Url: https://codereview.chromium.org/2861633002
Cr-Commit-Position: refs/heads/master@{#469282}
Committed:
https://chromium.googlesource.com/chromium/src/+/b0f43286afa116cc6ac6160cbf9c...
==========

[commit-bot: I haz the power, 2017-05-04 06:03:44]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/b0f43286afa116cc6ac6160cbf9c...