Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 2861613003: Disable ManagePasswordsBubbleDialogViewTest.InvokeDialog_ManagePasswordBubble (Closed)

Created:
3 years, 7 months ago by tapted
Modified:
3 years, 7 months ago
Reviewers:
vabr (Chromium)
CC:
chromium-reviews, tfarina, gcasto+watchlist_chromium.org, vabr+watchlistpasswordmanager_chromium.org, chrome-apps-syd-reviews_chromium.org, vasilii, kylix_rd
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable ManagePasswordsBubbleDialogViewTest.InvokeDialog_ManagePasswordBubble ExecuteManagePasswordsCommand() spins a runloop which will be flaky in a browser test. BUG=716681 Review-Url: https://codereview.chromium.org/2861613003 Cr-Commit-Position: refs/heads/master@{#468940} Committed: https://chromium.googlesource.com/chromium/src/+/2a1bf28fa972d7ae12268ff9caa7523d5b8fc518

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M chrome/browser/ui/views/passwords/manage_passwords_bubble_view_browsertest.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 12 (8 generated)
tapted
please take a look - thanks!
3 years, 7 months ago (2017-05-03 09:38:10 UTC) #2
vabr (Chromium)
Thanks for the analysis regarding the runloop. Disabling LGTM. I am adding the test author, ...
3 years, 7 months ago (2017-05-03 10:19:39 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2861613003/1
3 years, 7 months ago (2017-05-03 11:20:00 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-05-03 11:24:00 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/2a1bf28fa972d7ae12268ff9caa7...

Powered by Google App Engine
This is Rietveld 408576698