Reland: Do not kill recently killed ARC processes again

Reland: Do not kill recently killed ARC processes again

ARC processes sometimes respawn right after being killed. In that case,
killing them every time is just a waste of resources.

BUG=706048
TEST=try
TEST=Follow crbug.com/706048#c76, confirm Chrome no longer kills the
 processes too often.
TEST=gn gen out/Debug --args='is_debug=true use_goma=true target_os="chromeos"
 is_component_build=true remove_webcore_debug_symbols=true' &&
 ninja -C out/Debug unit_tests

Review-Url: https://codereview.chromium.org/2861613002
Cr-Commit-Position: refs/heads/master@{#469092}
Committed: https://chromium.googlesource.com/chromium/src/+/eba2b9c32c0df7536d5884ab0d645b2701815206

[Yusuke Sato, 2017-05-03 02:08:01]

The CQ bit was checked by yusukes@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-03 02:08:22]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-03 02:44:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-03 02:44:23]

Dry run: This issue passed the CQ dry run.

[Yusuke Sato, 2017-05-03 03:04:11]

yusukes@chromium.org changed reviewers:
+ georgesak@chromium.org

[Yusuke Sato, 2017-05-03 03:04:11]

Georges, could you have a look at this reland change? The only modification I
did was
https://codereview.chromium.org/2861613002/diff2/1:20001/chrome/browser/memor...
.

Thanks!
Yusuke

[Yusuke Sato, 2017-05-03 03:05:11]

I also confirmed that with the change, debug chromeos build now pass.

[cylee1, 2017-05-03 16:51:59]

cylee@chromium.org changed reviewers:
+ cylee@chromium.org

[cylee1, 2017-05-03 16:51:59]

lgtm

[Georges Khalil, 2017-05-03 18:46:11]

Owner LGTM % nit.

https://codereview.chromium.org/2861613002/diff/20001/chrome/browser/memory/t...
File chrome/browser/memory/tab_manager_delegate_chromeos.h (right):

https://codereview.chromium.org/2861613002/diff/20001/chrome/browser/memory/t...
chrome/browser/memory/tab_manager_delegate_chromeos.h:103:
DoNotKillRecentlyKilledArcProcesses);
nit: alphabetical order.

[Yusuke Sato, 2017-05-03 19:24:37]

Thanks!

https://codereview.chromium.org/2861613002/diff/20001/chrome/browser/memory/t...
File chrome/browser/memory/tab_manager_delegate_chromeos.h (right):

https://codereview.chromium.org/2861613002/diff/20001/chrome/browser/memory/t...
chrome/browser/memory/tab_manager_delegate_chromeos.h:103:
DoNotKillRecentlyKilledArcProcesses);
On 2017/05/03 18:46:11, Georges Khalil wrote:
> nit: alphabetical order.

Done.

[Yusuke Sato, 2017-05-03 19:24:45]

The CQ bit was checked by yusukes@chromium.org

[Yusuke Sato, 2017-05-03 19:24:46]

The patchset sent to the CQ was uploaded after l-g-t-m from cylee@chromium.org,
georgesak@chromium.org
Link to the patchset: https://codereview.chromium.org/2861613002/#ps40001
(title: "address comment")

[commit-bot: I haz the power, 2017-05-03 19:25:28]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-03 20:02:18]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1493839485667920,
"parent_rev": "0bd025a8364447a590adfb10cde4d9691ee7d68d", "commit_rev":
"eba2b9c32c0df7536d5884ab0d645b2701815206"}

[commit-bot: I haz the power, 2017-05-03 20:02:29]

Description was changed from

==========
Reland: Do not kill recently killed ARC processes again

ARC processes sometimes respawn right after being killed. In that case,
killing them every time is just a waste of resources.

BUG=706048
TEST=try
TEST=Follow crbug.com/706048#c76, confirm Chrome no longer kills the
 processes too often.
TEST=gn gen out/Debug --args='is_debug=true use_goma=true target_os="chromeos"
 is_component_build=true remove_webcore_debug_symbols=true' &&
 ninja -C out/Debug unit_tests
==========

to

==========
Reland: Do not kill recently killed ARC processes again

ARC processes sometimes respawn right after being killed. In that case,
killing them every time is just a waste of resources.

BUG=706048
TEST=try
TEST=Follow crbug.com/706048#c76, confirm Chrome no longer kills the
 processes too often.
TEST=gn gen out/Debug --args='is_debug=true use_goma=true target_os="chromeos"
 is_component_build=true remove_webcore_debug_symbols=true' &&
 ninja -C out/Debug unit_tests

Review-Url: https://codereview.chromium.org/2861613002
Cr-Commit-Position: refs/heads/master@{#469092}
Committed:
https://chromium.googlesource.com/chromium/src/+/eba2b9c32c0df7536d5884ab0d64...
==========

[commit-bot: I haz the power, 2017-05-03 20:02:29]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/eba2b9c32c0df7536d5884ab0d64...