Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Issue 2861603003: Remove SupportsWeakPtr from VideoCaptureDeviceClient (Closed)

Created:
3 years, 7 months ago by Chandan
Modified:
3 years, 7 months ago
Reviewers:
chfremer
CC:
chromium-reviews, posciak+watch_chromium.org, chfremer+watch_chromium.org, xjz+watch_chromium.org, feature-media-reviews_chromium.org, miu+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove SupportsWeakPtr from VideoCaptureDeviceClient VideoCaptureDeviceClient unnecessarily inherits SupportsWeakPtr. BUG=None Review-Url: https://codereview.chromium.org/2861603003 Cr-Commit-Position: refs/heads/master@{#469072} Committed: https://chromium.googlesource.com/chromium/src/+/2d691f86ea2a0e9057f82a4ae28f7c00fff26f6e

Patch Set 1 #

Patch Set 2 : removed weak_ptr.h #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M media/capture/video/video_capture_device_client.h View 1 2 chunks +1 line, -3 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Chandan
PTAL. Thank you.
3 years, 7 months ago (2017-05-03 12:17:36 UTC) #2
chfremer
lgtm
3 years, 7 months ago (2017-05-03 16:24:32 UTC) #3
Chandan
On 2017/05/03 16:24:32, chfremer wrote: > lgtm Thanks chfremer@. Is it possible on your part ...
3 years, 7 months ago (2017-05-03 17:37:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2861603003/20001
3 years, 7 months ago (2017-05-03 17:37:51 UTC) #6
commit-bot: I haz the power
3 years, 7 months ago (2017-05-03 19:27:43 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/2d691f86ea2a0e9057f82a4ae28f...

Powered by Google App Engine
This is Rietveld 408576698