Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Issue 2861583006: Use constexpr TaskTraits constructor in ios. (Closed)

Created:
3 years, 7 months ago by fdoray
Modified:
3 years, 7 months ago
CC:
chromium-reviews, Eugene But (OOO till 7-30), cbentzel+watch_chromium.org, ios-reviews+web_chromium.org, ios-reviews_chromium.org, net-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Use constexpr TaskTraits constructor in ios. Use a constexpr constructor that accepts traits in any order instead of the builder pattern to construct TaskTraits in ios. BUG=713683 R=gab@chromium.org TBR=eugenebut@chromium.org Review-Url: https://codereview.chromium.org/2861583006 Cr-Commit-Position: refs/heads/master@{#469111} Committed: https://chromium.googlesource.com/chromium/src/+/53ccd976b39d1f456269dce73444551a1feeddc7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M ios/web/net/crw_cert_verification_controller.mm View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
fdoray
3 years, 7 months ago (2017-05-03 20:23:29 UTC) #1
fdoray
gab@: PTAL The change will then be TBRed to the owner.
3 years, 7 months ago (2017-05-03 20:23:32 UTC) #3
gab
lgtm
3 years, 7 months ago (2017-05-03 20:38:28 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2861583006/1
3 years, 7 months ago (2017-05-03 20:43:35 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/53ccd976b39d1f456269dce73444551a1feeddc7
3 years, 7 months ago (2017-05-03 20:48:34 UTC) #12
Eugene But (OOO till 7-30)
3 years, 7 months ago (2017-05-08 15:32:28 UTC) #13
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698