Enable sequential prefix index logs to be loaded.

Enable sequential prefix index logs to be loaded.

The LogDog viewer requires at least one log from each muxing stream to
know which one is sequentially next. For timestamp-based comparison, this is
a hard requirement, since the next log in any given stream could be
sequentially next. However, for prefix index-based comparison, the
viewer could know that a log from another buffer is next if its prefix
index is contiguous.

Enable this inference in the viewer: if a log stream buffer holds a
prefix index that is one more than the last buffered log, allow it to be
considered as the next log, even if other buffers are empty.

BUG=chromium:703428
TEST=prod

Review-Url: https://codereview.chromium.org/2861583003
Committed: https://github.com/luci/luci-go/commit/2944f11ecd9ab8b74ccdde28c5a6bd01a488aa85

[dnj, 2017-05-03 02:24:04]

dnj@chromium.org changed reviewers:
+ hinoka@chromium.org, nodir@chromium.org

[dnj, 2017-05-03 02:24:05]

PTAL

[hinoka, 2017-05-03 17:16:58]

lgtm

https://codereview.chromium.org/2861583003/diff/1/web/inc/logdog-stream-view/...
File web/inc/logdog-stream-view/viewer.ts (right):

https://codereview.chromium.org/2861583003/diff/1/web/inc/logdog-stream-view/...
web/inc/logdog-stream-view/viewer.ts:1001: * LogSorter is used to extract sorted
logs from a set of BufferedLogs.
LogSorter is an interface used to....

https://codereview.chromium.org/2861583003/diff/1/web/inc/logdog-stream-view/...
web/inc/logdog-stream-view/viewer.ts:1003: * LogSorter will modify the
BufferedLogs, consuming the logs that it
A LogSorter which implements implicitNext() will modify the...

https://codereview.chromium.org/2861583003/diff/1/web/inc/logdog-stream-view/...
web/inc/logdog-stream-view/viewer.ts:1244: let last: LogDog.LogEntry|null =
null;
how about "current"? "last" often implies "final", which this isn't.

[dnj, 2017-05-03 19:09:28]

https://codereview.chromium.org/2861583003/diff/1/web/inc/logdog-stream-view/...
File web/inc/logdog-stream-view/viewer.ts (right):

https://codereview.chromium.org/2861583003/diff/1/web/inc/logdog-stream-view/...
web/inc/logdog-stream-view/viewer.ts:1001: * LogSorter is used to extract sorted
logs from a set of BufferedLogs.
On 2017/05/03 17:16:58, hinoka wrote:
> LogSorter is an interface used to....

Done.

https://codereview.chromium.org/2861583003/diff/1/web/inc/logdog-stream-view/...
web/inc/logdog-stream-view/viewer.ts:1003: * LogSorter will modify the
BufferedLogs, consuming the logs that it
On 2017/05/03 17:16:58, hinoka wrote:
> A LogSorter which implements implicitNext() will modify the...

Done.

https://codereview.chromium.org/2861583003/diff/1/web/inc/logdog-stream-view/...
web/inc/logdog-stream-view/viewer.ts:1244: let last: LogDog.LogEntry|null =
null;
On 2017/05/03 17:16:58, hinoka wrote:
> how about "current"? "last" often implies "final", which this isn't.

Renamed to "latestAdded".

[dnj, 2017-05-03 19:09:31]

The CQ bit was checked by dnj@chromium.org

[dnj, 2017-05-03 19:09:31]

The patchset sent to the CQ was uploaded after l-g-t-m from hinoka@chromium.org
Link to the patchset: https://codereview.chromium.org/2861583003/#ps20001
(title: "comments")

[commit-bot: I haz the power, 2017-05-03 19:09:36]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-03 19:16:07]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1493838571513330,
"parent_rev": "e8d922622c9b85a78d7b8a93de254156247d0dbc", "commit_rev":
"2944f11ecd9ab8b74ccdde28c5a6bd01a488aa85"}

[commit-bot: I haz the power, 2017-05-03 19:16:10]

Description was changed from

==========
Enable sequential prefix index logs to be loaded.

The LogDog viewer requires at least one log from each muxing stream to
know which one is sequentially next. For timestamp-based comparison, this is
a hard requirement, since the next log in any given stream could be
sequentially next. However, for prefix index-based comparison, the
viewer could know that a log from another buffer is next if its prefix
index is contiguous.

Enable this inference in the viewer: if a log stream buffer holds a
prefix index that is one more than the last buffered log, allow it to be
considered as the next log, even if other buffers are empty.

BUG=chromium:703428
TEST=prod
==========

to

==========
Enable sequential prefix index logs to be loaded.

The LogDog viewer requires at least one log from each muxing stream to
know which one is sequentially next. For timestamp-based comparison, this is
a hard requirement, since the next log in any given stream could be
sequentially next. However, for prefix index-based comparison, the
viewer could know that a log from another buffer is next if its prefix
index is contiguous.

Enable this inference in the viewer: if a log stream buffer holds a
prefix index that is one more than the last buffered log, allow it to be
considered as the next log, even if other buffers are empty.

BUG=chromium:703428
TEST=prod

Review-Url: https://codereview.chromium.org/2861583003
Committed:
https://github.com/luci/luci-go/commit/2944f11ecd9ab8b74ccdde28c5a6bd01a488aa85
==========

[commit-bot: I haz the power, 2017-05-03 19:16:11]

Committed patchset #2 (id:20001) as
https://github.com/luci/luci-go/commit/2944f11ecd9ab8b74ccdde28c5a6bd01a488aa85