Isolate tests that initialize ServiceManagerConnection

Isolate tests that initialize ServiceManagerConnection

Some unit tests initialize ServiceManagerConnection and leave it initialized
(e.g. in RenderProcessHostImpl::InitializeChannelProxy). On the other hand,
tests that use TestServiceManagerContext/ServiceManagerContext expect
ServiceManagerConnection to be unitialized on test start or
DCHECK(!g_connection_for_process.Get()) fails.
Change to explicitly uninitialize ServiceManagerConnection on creation of
TestServiceManagerContext.

BUG=717928, 697217
Review-Url: https://codereview.chromium.org/2861503003
Cr-Commit-Position: refs/heads/master@{#471696}
Committed: https://chromium.googlesource.com/chromium/src/+/5ffddc43be38516f89c6c631872285324778eb39

[olegmax, 2017-05-03 10:48:39]

Description was changed from

==========
Isolate tests that initialize ServiceManagerConnection

Some unit tests initialize ServiceManagerConnection and leave it initialized
(e.g. in RenderProcessHostImpl::InitializeChannelProxy). On the other hand,
tests that use TestServiceManagerContext/ServiceManagerContext expect
ServiceManagerConnection to be unitialized on test start or
DCHECK(!g_connection_for_process.Get()) fails.
Change to explicitly uninitialize ServiceManagerConnection on creation of
TestServiceManagerContext.

BUG=717928
==========

to

==========
Isolate tests that initialize ServiceManagerConnection

Some unit tests initialize ServiceManagerConnection and leave it initialized
(e.g. in RenderProcessHostImpl::InitializeChannelProxy). On the other hand,
tests that use TestServiceManagerContext/ServiceManagerContext expect
ServiceManagerConnection to be unitialized on test start or
DCHECK(!g_connection_for_process.Get()) fails.
Change to explicitly uninitialize ServiceManagerConnection on creation of
TestServiceManagerContext.

BUG=717928
==========

[olegmax, 2017-05-03 10:48:40]

olegmax@yandex-team.ru changed reviewers:
+ rockot@chromium.org

[olegmax, 2017-05-03 15:29:13]

Description was changed from

==========
Isolate tests that initialize ServiceManagerConnection

Some unit tests initialize ServiceManagerConnection and leave it initialized
(e.g. in RenderProcessHostImpl::InitializeChannelProxy). On the other hand,
tests that use TestServiceManagerContext/ServiceManagerContext expect
ServiceManagerConnection to be unitialized on test start or
DCHECK(!g_connection_for_process.Get()) fails.
Change to explicitly uninitialize ServiceManagerConnection on creation of
TestServiceManagerContext.

BUG=717928
==========

to

==========
Isolate tests that initialize ServiceManagerConnection

Some unit tests initialize ServiceManagerConnection and leave it initialized
(e.g. in RenderProcessHostImpl::InitializeChannelProxy). On the other hand,
tests that use TestServiceManagerContext/ServiceManagerContext expect
ServiceManagerConnection to be unitialized on test start or
DCHECK(!g_connection_for_process.Get()) fails.
Change to explicitly uninitialize ServiceManagerConnection on creation of
TestServiceManagerContext.

BUG=717928,697217
==========

[Ken Rockot(use gerrit already), 2017-05-03 17:41:49]

lgtm

[olegmax, 2017-05-04 06:20:39]

The CQ bit was checked by olegmax@yandex-team.ru to run a CQ dry run

[commit-bot: I haz the power, 2017-05-04 06:20:51]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-04 07:12:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-04 07:12:59]

Dry run: This issue passed the CQ dry run.

[olegmax, 2017-05-04 07:18:15]

olegmax@yandex-team.ru changed reviewers:
+ phajdan.jr@chromium.org

[Paweł Hajdan Jr., 2017-05-05 17:29:36]

LGTM

[olegmax, 2017-05-15 07:08:12]

The CQ bit was checked by olegmax@yandex-team.ru

[commit-bot: I haz the power, 2017-05-15 07:08:29]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-15 08:26:17]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1494832092136930, "parent_rev":
"c225554c76560232dbb8813c96038351c03aceae", "commit_rev":
"5ffddc43be38516f89c6c631872285324778eb39"}

[commit-bot: I haz the power, 2017-05-15 08:26:34]

Description was changed from

==========
Isolate tests that initialize ServiceManagerConnection

Some unit tests initialize ServiceManagerConnection and leave it initialized
(e.g. in RenderProcessHostImpl::InitializeChannelProxy). On the other hand,
tests that use TestServiceManagerContext/ServiceManagerContext expect
ServiceManagerConnection to be unitialized on test start or
DCHECK(!g_connection_for_process.Get()) fails.
Change to explicitly uninitialize ServiceManagerConnection on creation of
TestServiceManagerContext.

BUG=717928,697217
==========

to

==========
Isolate tests that initialize ServiceManagerConnection

Some unit tests initialize ServiceManagerConnection and leave it initialized
(e.g. in RenderProcessHostImpl::InitializeChannelProxy). On the other hand,
tests that use TestServiceManagerContext/ServiceManagerContext expect
ServiceManagerConnection to be unitialized on test start or
DCHECK(!g_connection_for_process.Get()) fails.
Change to explicitly uninitialize ServiceManagerConnection on creation of
TestServiceManagerContext.

BUG=717928,697217

Review-Url: https://codereview.chromium.org/2861503003
Cr-Commit-Position: refs/heads/master@{#471696}
Committed:
https://chromium.googlesource.com/chromium/src/+/5ffddc43be38516f89c6c6318722...
==========

[commit-bot: I haz the power, 2017-05-15 08:26:35]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/5ffddc43be38516f89c6c6318722...