[PageLoadMetrics] Reland - Keep track of Ad Sizes on Pages

Reland of https://codereview.chromium.org/2798953002 where the observer is disabled since it's still broken.

[PageLoadMetrics] Keep track of Ad Sizes on Pages

In order to help us understand the resource footprint that ads have on
webpages, we need to measure things like their network and cache utilizations.
This CL adds a PageLoadObserver that keeps track of frames with ads and
reports statistics on the number of ad frames found on the page, the size of
the ad frames, and the percentage that came from cache vs network.

As part of the work, the following additional changes were necessary:

1) Frame Tree ID and URL are added to extra request info
2) Add GetRenderFrameHostGetterForRequest to ResourceRequestInfo so that
   ChromeResourceDispatcherHostDelegate can get at the frame tree node id of
   the resource.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
BUG=708570, 717892
TBR=bmcquade,clamy,jam,csharrison,isherman

Review-Url: https://codereview.chromium.org/2861473003
Cr-Commit-Position: refs/heads/master@{#469042}
Committed: https://chromium.googlesource.com/chromium/src/+/73af8befbc973943ac062ccd7d48b73ecc61de60

[jkarlin, 2017-05-03 17:21:20]

Description was changed from

==========
[PageLoadMetrics] Keep track of Ad Sizes on Pages

In order to help us understand the resource footprint that ads have on
webpages, we need to measure things like their network and cache utilizations.
This CL adds a PageLoadObserver that keeps track of frames with ads and
reports statistics on the number of ad frames found on the page, the size of
the ad frames, and the percentage that came from cache vs network.

As part of the work, the following additional changes were necessary:

1) Frame Tree ID and URL are added to extra request info
2) Add GetRenderFrameHostGetterForRequest to ResourceRequestInfo so that
   ChromeResourceDispatcherHostDelegate can get at the frame tree node id of
   the resource.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
BUG=708570

Review-Url: https://codereview.chromium.org/2798953002
Cr-Commit-Position: refs/heads/master@{#468738}
Committed:
https://chromium.googlesource.com/chromium/src/+/6616a885b4f18edd4f6aa178146c...

patch from issue 2798953002 at patchset 640001
(http://crrev.com/2798953002#ps640001)
==========

to

==========
Reland of https://codereview.chromium.org/2798953002 where the observer is
disabled since it's still broken.

[PageLoadMetrics] Keep track of Ad Sizes on Pages

In order to help us understand the resource footprint that ads have on
webpages, we need to measure things like their network and cache utilizations.
This CL adds a PageLoadObserver that keeps track of frames with ads and
reports statistics on the number of ad frames found on the page, the size of
the ad frames, and the percentage that came from cache vs network.

As part of the work, the following additional changes were necessary:

1) Frame Tree ID and URL are added to extra request info
2) Add GetRenderFrameHostGetterForRequest to ResourceRequestInfo so that
   ChromeResourceDispatcherHostDelegate can get at the frame tree node id of
   the resource.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
BUG=708570
==========

[jkarlin, 2017-05-03 17:24:39]

The CQ bit was checked by jkarlin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-03 17:25:27]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jkarlin, 2017-05-03 17:29:17]

Description was changed from

==========
Reland of https://codereview.chromium.org/2798953002 where the observer is
disabled since it's still broken.

[PageLoadMetrics] Keep track of Ad Sizes on Pages

In order to help us understand the resource footprint that ads have on
webpages, we need to measure things like their network and cache utilizations.
This CL adds a PageLoadObserver that keeps track of frames with ads and
reports statistics on the number of ad frames found on the page, the size of
the ad frames, and the percentage that came from cache vs network.

As part of the work, the following additional changes were necessary:

1) Frame Tree ID and URL are added to extra request info
2) Add GetRenderFrameHostGetterForRequest to ResourceRequestInfo so that
   ChromeResourceDispatcherHostDelegate can get at the frame tree node id of
   the resource.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
BUG=708570
==========

to

==========
Reland of https://codereview.chromium.org/2798953002 where the observer is
disabled since it's still broken.

[PageLoadMetrics] Keep track of Ad Sizes on Pages

In order to help us understand the resource footprint that ads have on
webpages, we need to measure things like their network and cache utilizations.
This CL adds a PageLoadObserver that keeps track of frames with ads and
reports statistics on the number of ad frames found on the page, the size of
the ad frames, and the percentage that came from cache vs network.

As part of the work, the following additional changes were necessary:

1) Frame Tree ID and URL are added to extra request info
2) Add GetRenderFrameHostGetterForRequest to ResourceRequestInfo so that
   ChromeResourceDispatcherHostDelegate can get at the frame tree node id of
   the resource.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
BUG=708570

TBR=bmcquade,clamy,jam,csharrison,isherman
==========

[Charlie Harrison, 2017-05-03 17:30:33]

csharrison@chromium.org changed reviewers:
+ csharrison@chromium.org

[Charlie Harrison, 2017-05-03 17:30:33]

LGTM

[jkarlin, 2017-05-03 17:31:07]

Description was changed from

==========
Reland of https://codereview.chromium.org/2798953002 where the observer is
disabled since it's still broken.

[PageLoadMetrics] Keep track of Ad Sizes on Pages

In order to help us understand the resource footprint that ads have on
webpages, we need to measure things like their network and cache utilizations.
This CL adds a PageLoadObserver that keeps track of frames with ads and
reports statistics on the number of ad frames found on the page, the size of
the ad frames, and the percentage that came from cache vs network.

As part of the work, the following additional changes were necessary:

1) Frame Tree ID and URL are added to extra request info
2) Add GetRenderFrameHostGetterForRequest to ResourceRequestInfo so that
   ChromeResourceDispatcherHostDelegate can get at the frame tree node id of
   the resource.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
BUG=708570

TBR=bmcquade,clamy,jam,csharrison,isherman
==========

to

==========
Reland of https://codereview.chromium.org/2798953002 where the observer is
disabled since it's still broken.

[PageLoadMetrics] Keep track of Ad Sizes on Pages

In order to help us understand the resource footprint that ads have on
webpages, we need to measure things like their network and cache utilizations.
This CL adds a PageLoadObserver that keeps track of frames with ads and
reports statistics on the number of ad frames found on the page, the size of
the ad frames, and the percentage that came from cache vs network.

As part of the work, the following additional changes were necessary:

1) Frame Tree ID and URL are added to extra request info
2) Add GetRenderFrameHostGetterForRequest to ResourceRequestInfo so that
   ChromeResourceDispatcherHostDelegate can get at the frame tree node id of
   the resource.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
BUG=708570,717892

TBR=bmcquade,clamy,jam,csharrison,isherman
==========

[Charlie Harrison, 2017-05-03 17:31:20]

Can you include in the comments what has changed with this CL?

[jkarlin, 2017-05-03 17:33:20]

On 2017/05/03 17:31:20, Charlie Harrison wrote:
> Can you include in the comments what has changed with this CL?

It's in the CL description (first line). Is that what you meant?

[jkarlin, 2017-05-03 17:34:08]

The CQ bit was unchecked by jkarlin@chromium.org

[jkarlin, 2017-05-03 17:34:13]

The CQ bit was checked by jkarlin@chromium.org

[commit-bot: I haz the power, 2017-05-03 17:34:30]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Charlie Harrison, 2017-05-03 17:35:28]

On 2017/05/03 17:33:20, jkarlin wrote:
> On 2017/05/03 17:31:20, Charlie Harrison wrote:
> > Can you include in the comments what has changed with this CL?
> 
> It's in the CL description (first line). Is that what you meant?

Ah, sorry about that my eyes skimmed over it since usually the first line is the
same as the issue title.

[commit-bot: I haz the power, 2017-05-03 18:37:01]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1493832853607940,
"parent_rev": "67ed4ef8a3ce933aa10a02cd36dc4e91f3fe9019", "commit_rev":
"73af8befbc973943ac062ccd7d48b73ecc61de60"}

[commit-bot: I haz the power, 2017-05-03 18:38:06]

Description was changed from

==========
Reland of https://codereview.chromium.org/2798953002 where the observer is
disabled since it's still broken.

[PageLoadMetrics] Keep track of Ad Sizes on Pages

In order to help us understand the resource footprint that ads have on
webpages, we need to measure things like their network and cache utilizations.
This CL adds a PageLoadObserver that keeps track of frames with ads and
reports statistics on the number of ad frames found on the page, the size of
the ad frames, and the percentage that came from cache vs network.

As part of the work, the following additional changes were necessary:

1) Frame Tree ID and URL are added to extra request info
2) Add GetRenderFrameHostGetterForRequest to ResourceRequestInfo so that
   ChromeResourceDispatcherHostDelegate can get at the frame tree node id of
   the resource.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
BUG=708570,717892

TBR=bmcquade,clamy,jam,csharrison,isherman
==========

to

==========
Reland of https://codereview.chromium.org/2798953002 where the observer is
disabled since it's still broken.

[PageLoadMetrics] Keep track of Ad Sizes on Pages

In order to help us understand the resource footprint that ads have on
webpages, we need to measure things like their network and cache utilizations.
This CL adds a PageLoadObserver that keeps track of frames with ads and
reports statistics on the number of ad frames found on the page, the size of
the ad frames, and the percentage that came from cache vs network.

As part of the work, the following additional changes were necessary:

1) Frame Tree ID and URL are added to extra request info
2) Add GetRenderFrameHostGetterForRequest to ResourceRequestInfo so that
   ChromeResourceDispatcherHostDelegate can get at the frame tree node id of
   the resource.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
BUG=708570,717892

TBR=bmcquade,clamy,jam,csharrison,isherman

Review-Url: https://codereview.chromium.org/2861473003
Cr-Commit-Position: refs/heads/master@{#469042}
Committed:
https://chromium.googlesource.com/chromium/src/+/73af8befbc973943ac062ccd7d48...
==========

[commit-bot: I haz the power, 2017-05-03 18:38:07]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/73af8befbc973943ac062ccd7d48...