Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 2861443006: [turbofan] Extend Array.prototype.pop lowering to support FAST_DOUBLE_ELEMENTS. (Closed)

Created:
3 years, 7 months ago by Benedikt Meurer
Modified:
3 years, 7 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Extend Array.prototype.pop lowering to support FAST_DOUBLE_ELEMENTS. So far the Array.prototype.pop lowering in the JSBuiltinReducer was limited to (holey) fast or fast-smi elements. But it can be made to work easily to also handle fast-double elements, so allow that as well. R=jarin@chromium.org BUG=v8:5267, v8:6338 Review-Url: https://codereview.chromium.org/2861443006 Cr-Commit-Position: refs/heads/master@{#45090} Committed: https://chromium.googlesource.com/v8/v8/+/5c433ec500e0de20737624bceb0ade69d67a9153

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -5 lines) Patch
M src/compiler/js-builtin-reducer.cc View 2 chunks +7 lines, -5 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
Benedikt Meurer
3 years, 7 months ago (2017-05-04 11:38:23 UTC) #1
Jarin
lgtm
3 years, 7 months ago (2017-05-04 11:45:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2861443006/1
3 years, 7 months ago (2017-05-04 11:49:08 UTC) #7
commit-bot: I haz the power
3 years, 7 months ago (2017-05-04 12:36:05 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/5c433ec500e0de20737624bceb0ade69d67...

Powered by Google App Engine
This is Rietveld 408576698