Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4989)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/resources/settings/privacy_page/privacy_page.js

Issue 2861443003: MD Settings: Fix subpage visibility and add appearance page tests (Closed)
Patch Set: Rebase Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/resources/settings/basic_page/basic_page.html ('K') | « chrome/browser/resources/settings/privacy_page/privacy_page.html ('k') | chrome/test/data/webui/settings/appearance_page_test.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/settings/privacy_page/privacy_page.js
diff --git a/chrome/browser/resources/settings/privacy_page/privacy_page.js b/chrome/browser/resources/settings/privacy_page/privacy_page.js
index 2131c6adcc1e6bad1f3f2121fe3628a7370309ac..4defa87002a97dec6500c1e95db25088c87fef43 100644
--- a/chrome/browser/resources/settings/privacy_page/privacy_page.js
+++ b/chrome/browser/resources/settings/privacy_page/privacy_page.js
@@ -150,6 +150,15 @@ Polymer({
},
/**
+ * @param {boolean|undefined} visibility
+ * @return {boolean}
+ * @private
+ */
+ showPage_: function(visibility) {
+ return visibility !== false;
+ },
+
+ /**
* @param {Event} event
* @private
*/
« chrome/browser/resources/settings/basic_page/basic_page.html ('K') | « chrome/browser/resources/settings/privacy_page/privacy_page.html ('k') | chrome/test/data/webui/settings/appearance_page_test.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698