MD Settings: Fix subpage visibility and add appearance page tests

chrome/test/data/webui/settings/appearance_page_test.js

Index: chrome/test/data/webui/settings/appearance_page_test.js
diff --git a/chrome/test/data/webui/settings/appearance_page_test.js b/chrome/test/data/webui/settings/appearance_page_test.js
index bc3cb043002f6b400580fede4c6ca353331a0797..d2462bd02def62a4d7e1d180927221b8c3a6f55a 100644
--- a/chrome/test/data/webui/settings/appearance_page_test.js
+++ b/chrome/test/data/webui/settings/appearance_page_test.js
@@ -110,11 +110,46 @@ function createAppearancePage() {
       },
     },
   });
+  appearancePage.set('pageVisibility', {});
 
   document.body.appendChild(appearancePage);
   Polymer.dom.flush();
 }
 
+suite('AppearancePageVisibility', function() {
+  setup(function() {
+    appearanceBrowserProxy = new TestAppearanceBrowserProxy();
+    settings.AppearanceBrowserProxyImpl.instance_ = appearanceBrowserProxy;
+    createAppearancePage();
+  });
+
+  teardown(function() {
+    appearancePage.remove();
+  });
+
+  if (cr.isChromeOS) {
+    test('setWallpaper', function() {
+      assertTrue(!!appearancePage.$$('#setWallpaper'));
+    });
+  } else {
+    test('noSetWallpaper', function() {
+      assertTrue(!appearancePage.$$('#setWallpaper'));
+    });
+  }
+
+  test('setTheme', function() {
+    assertTrue(!!appearancePage.$$('#setTheme'));
+  });
+
+  test('homeButton', function() {
+    assertTrue(!!appearancePage.$$('#homeButton'));

[dpapad, 2017/05/04 01:03:24]

Now that we don't use dom-if, these tests are insufficient (they check existence
which is always true, and therefore did not catch the problem mentioned in
previous comment).

+  });
+
+  test('bookmarksBar', function() {
+    assertTrue(!!appearancePage.$$('#bookmarksBar'));
+  });
+});
+
 suite('AppearanceHandler', function() {
   setup(function() {
     appearanceBrowserProxy = new TestAppearanceBrowserProxy();
@@ -126,7 +161,7 @@ suite('AppearanceHandler', function() {
 
   if (cr.isChromeOS) {
     test('wallpaperManager', function() {
-      var button = appearancePage.$.wallpaperButton;
+      var button = appearancePage.$$('#setWallpaper');
       assertTrue(!!button);
       MockInteractions.tap(button);
       return appearanceBrowserProxy.whenCalled('openWallpaperManager');
@@ -134,7 +169,7 @@ suite('AppearanceHandler', function() {
   } else {
     test('noWallpaperManager', function() {
       // The wallpaper button should not be present.
-      var button = appearancePage.$.wallpaperButton;
+      var button = appearancePage.$$('#setWallpaper');
       assertFalse(!!button);
     });
   }
@@ -215,7 +250,7 @@ suite('AppearanceHandler', function() {
 
   test('default zoom handling', function() {
     function getDefaultZoomText() {
-      var zoomLevel = appearancePage.$.zoomLevel;
+      var zoomLevel = appearancePage.$$('#zoomLevel');
       return zoomLevel.options[zoomLevel.selectedIndex].textContent.trim();
     }
 
@@ -289,4 +324,4 @@ suite('HomeUrlInput', function() {
           assertEquals(homeUrlInput.value, 'test');
         });
   });
-});
+});