MD Settings: Fix subpage visibility and add appearance page tests

chrome/browser/resources/settings/basic_page/basic_page.js

Index: chrome/browser/resources/settings/basic_page/basic_page.js
diff --git a/chrome/browser/resources/settings/basic_page/basic_page.js b/chrome/browser/resources/settings/basic_page/basic_page.js
index 4032ade5091d750830b47e9b0c096be08ad0edb6..169d9c3906be5111560c256b2f3a8e2bccbcbc97 100644
--- a/chrome/browser/resources/settings/basic_page/basic_page.js
+++ b/chrome/browser/resources/settings/basic_page/basic_page.js
@@ -142,11 +142,12 @@ Polymer({
   },
 
   /**
+   * @param {!PageVisibility} visibility
    * @param {string} subpage
    * @return {!Object}
    */
-  getPageVisibility_: function(subpage) {
-    return /** @type {Object} */ (this.get(subpage, this.pageVisibility)) || {};
+  getPageVisibility_: function(visibility, subpage) {
+    return /** @type {Object} */ (this.get(subpage, visibility)) || {};

[dpapad, 2017/05/04 01:03:24]

I tried the CL locally and I still see the sections hidden as in the bug report.
Played with it locally and it seems that this line needs to be as follows for it
to work:

return /** @type {Object} */ (this.get(subpage, visibility));

Essentially, now that we are using |hidden|, we should not be sending an empty
object to the the other pages (like appearance), because bindings like
hidden="[[!pageVisibility.homeButton]]"

evaluate to true, if pageVisibility is an empty object.

In retrospect, I think in the original CL we should
 1) not have changed the default value of settings-ui's pageVisibility
 2) have kept pageVisibility only used for "guestMode" and not bundle the
"show-android-apps" functionality into it (which is the reason we changed the
default value).

I hope this makes sense (just trying to help, given the complications that were
created by the original CL, which I should have been more thoroughly
reviewing.).

   },
 
 // <if expr="chromeos">