Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(529)

Issue 2861443002: (Fix landed) Revert of [CrOS Tether] Create HostScanCache, which caches scan results and inserts... (Closed)

Created:
3 years, 7 months ago by findit-for-me
Modified:
3 years, 7 months ago
CC:
chromium-reviews, extensions-reviews_chromium.org, jlklein+watch-tether_chromium.org, tengs+watch-tether_chromium.org, khorimoto+watch-tether_chromium.org, hansberry+watch-tether_chromium.org, jhawkins+watch-tether_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, lesliewatkins+watch-tether_chromium.org, stevenjb+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [CrOS Tether] Create HostScanCache, which caches scan results and inserts them into the network sta… (patchset #8 id:140001 of https://codereview.chromium.org/2852693004/ ) Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 468705 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzZiNWI3ZGUxMDM3NjQzNDA3MTFiYzk3MDg3OWNhZjRhZmVhYjIzYjAM Original issue's description: > [CrOS Tether] Create HostScanCache, which caches scan results and inserts them into the network stack. > > This CL also includes some code in the network stack to pipe scan results through and also includes a refactor of HostScanner, since that was the class which previously was in charge of passing scan results to the network stack. > > BUG=672263 > > Review-Url: https://codereview.chromium.org/2852693004 > Cr-Commit-Position: refs/heads/master@{#468705} > Committed: https://chromium.googlesource.com/chromium/src/+/6b5b7de103764340711bc970879caf4afeab23b0 TBR=stevenjb@chromium.org,hansberry@chromium.org,khorimoto@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=672263

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+123 lines, -1343 lines) Patch
M chromeos/components/tether/BUILD.gn View 3 chunks +0 lines, -5 lines 0 comments Download
D chromeos/components/tether/fake_host_scan_cache.h View 1 chunk +0 lines, -71 lines 0 comments Download
D chromeos/components/tether/fake_host_scan_cache.cc View 1 chunk +0 lines, -93 lines 0 comments Download
D chromeos/components/tether/host_scan_cache.h View 1 chunk +0 lines, -115 lines 0 comments Download
D chromeos/components/tether/host_scan_cache.cc View 1 chunk +0 lines, -227 lines 0 comments Download
D chromeos/components/tether/host_scan_cache_unittest.cc View 1 chunk +0 lines, -447 lines 0 comments Download
M chromeos/components/tether/host_scanner.h View 3 chunks +14 lines, -10 lines 0 comments Download
M chromeos/components/tether/host_scanner.cc View 4 chunks +39 lines, -46 lines 0 comments Download
M chromeos/components/tether/host_scanner_unittest.cc View 15 chunks +59 lines, -223 lines 0 comments Download
M chromeos/components/tether/initializer.h View 2 chunks +0 lines, -2 lines 0 comments Download
M chromeos/components/tether/initializer.cc View 2 chunks +2 lines, -7 lines 0 comments Download
M chromeos/components/tether/tether_host_response_recorder.h View 3 chunks +5 lines, -20 lines 0 comments Download
M chromeos/components/tether/tether_host_response_recorder.cc View 4 chunks +3 lines, -30 lines 0 comments Download
M chromeos/components/tether/tether_host_response_recorder_unittest.cc View 7 chunks +1 line, -47 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
findit-for-me
Created Revert of [CrOS Tether] Create HostScanCache, which caches scan results and inserts them into ...
3 years, 7 months ago (2017-05-02 19:07:43 UTC) #1
Kyle Horimoto
3 years, 7 months ago (2017-05-02 19:14:38 UTC) #2
On 2017/05/02 19:07:43, findit-for-me wrote:
> Created Revert of [CrOS Tether] Create HostScanCache, which caches scan
results
> and inserts them into the network sta…

I have a fix; let's land this instead:
https://codereview.chromium.org/2857723002

Powered by Google App Engine
This is Rietveld 408576698