Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(553)

Issue 2857723002: [CrOS Tether] Fix build breakage. (Closed)

Created:
3 years, 7 months ago by Kyle Horimoto
Modified:
3 years, 7 months ago
Reviewers:
stevenjb
CC:
chromium-reviews, jlklein+watch-tether_chromium.org, tengs+watch-tether_chromium.org, hansberry+watch-tether_chromium.org, jhawkins+watch-tether_chromium.org, oshima+watch_chromium.org, lesliewatkins+watch-tether_chromium.org, khorimoto+watch-tether_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[CrOS Tether] Fix build breakage. The issue was caused by https://codereview.chromium.org/2852693004, where I forgot to place an "= 0" at the end of a pure virtual function. TBR=stevenjb@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=672263 Review-Url: https://codereview.chromium.org/2857723002 Cr-Commit-Position: refs/heads/master@{#468736} Committed: https://chromium.googlesource.com/chromium/src/+/02e7e4c6c607cc2037d0d1d87617d4881f390abd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chromeos/components/tether/host_scan_cache.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (5 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2857723002/1
3 years, 7 months ago (2017-05-02 19:16:32 UTC) #4
commit-bot: I haz the power
3 years, 7 months ago (2017-05-02 19:17:21 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/02e7e4c6c607cc2037d0d1d87617...

Powered by Google App Engine
This is Rietveld 408576698