Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(524)

Issue 2861433006: Fix ChromeActivityTestCaseBase tearDown mistake (Closed)

Created:
3 years, 7 months ago by the real yoland
Modified:
3 years, 7 months ago
Reviewers:
jbudorick
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix ChromeActivityTestCaseBase tearDown mistake In the JUnit4 conversion CL (https://codereview.chromium.org/2815453003) super.tearDown() call was mistakenly removed. BUG=718454 Review-Url: https://codereview.chromium.org/2861433006 Cr-Commit-Position: refs/heads/master@{#469379} Committed: https://chromium.googlesource.com/chromium/src/+/240c255d33ba778844e6e86309400c4932298f6d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/test/android/javatests/src/org/chromium/chrome/test/ChromeActivityTestCaseBase.java View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
the real yoland
3 years, 7 months ago (2017-05-04 16:34:19 UTC) #2
jbudorick
lgtm
3 years, 7 months ago (2017-05-04 17:04:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2861433006/1
3 years, 7 months ago (2017-05-04 17:13:17 UTC) #5
commit-bot: I haz the power
3 years, 7 months ago (2017-05-04 18:13:30 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/240c255d33ba778844e6e8630940...

Powered by Google App Engine
This is Rietveld 408576698