DevTools/Coverage: fix decorations in HTML

DevTools/Coverage: fix decorations in HTML


- implement mapping for inline styles in HTML locally in CoverageDecorationsManager as a workaound for bindings deficiencies;
- apply proper offsets to inline resources when mapping UI positions to resource
    byte offsets in CoverageDecorationsManager;
- (drive-by) improve bar sizing precision in CoverageListView.

BUG=719113
Review-Url: https://codereview.chromium.org/2861393004
Cr-Commit-Position: refs/heads/master@{#471097}
Committed: https://chromium.googlesource.com/chromium/src/+/3431436da14fb7b435d830f8552280333a7dee8c

[caseq, 2017-05-09 01:25:23]

caseq@chromium.org changed reviewers:
+ dgozman@chromium.org, lushnikov@chromium.org

[caseq, 2017-05-10 01:51:10]

Description was changed from

==========
DevTools/Coverage: fix decorations in HTML

- support inline styles in
Bindings.cssWorkspaceBindgins.uiLocationToRawLocation();
- support binding multiple headers to single UISourceCode in
StylesSourceMapping;
- simplify mapping between UISourceCode and StyleFile in StylesSourceMapping;
- apply proper offsets to inline resources when mapping UI positions to resource
    byte offsets in CoverageDecorationsManager;
- (drive-by) improve bar sizing precision in CoverageListView.

BUG=719113
==========

to

==========
DevTools/Coverage: fix decorations in HTML

- support inline styles in
Bindings.cssWorkspaceBindgins.uiLocationToRawLocation();
- support binding multiple headers to single UISourceCode in
StylesSourceMapping;
- simplify mapping between UISourceCode and StyleFile in StylesSourceMapping;
- apply proper offsets to inline resources when mapping UI positions to resource
    byte offsets in CoverageDecorationsManager;
- (drive-by) improve bar sizing precision in CoverageListView.

BUG=719113
==========

[caseq, 2017-05-10 01:51:10]

caseq@chromium.org changed reviewers:
+ alph@chromium.org
- lushnikov@chromium.org

[caseq, 2017-05-10 01:51:48]

-lushnikov +alph -- ptal, I'm using a local workaround now instead of attempting
to fix bindings.

[caseq, 2017-05-10 01:55:35]

Patchset #3 (id:40001) has been deleted

[caseq, 2017-05-10 18:26:53]

Description was changed from

==========
DevTools/Coverage: fix decorations in HTML

- support inline styles in
Bindings.cssWorkspaceBindgins.uiLocationToRawLocation();
- support binding multiple headers to single UISourceCode in
StylesSourceMapping;
- simplify mapping between UISourceCode and StyleFile in StylesSourceMapping;
- apply proper offsets to inline resources when mapping UI positions to resource
    byte offsets in CoverageDecorationsManager;
- (drive-by) improve bar sizing precision in CoverageListView.

BUG=719113
==========

to

==========
DevTools/Coverage: fix decorations in HTML


- implement mapping for inline styles in HTML locally in
CoverageDecorationsManager as a workaound for bindings deficiencies;
- apply proper offsets to inline resources when mapping UI positions to resource
    byte offsets in CoverageDecorationsManager;
- (drive-by) improve bar sizing precision in CoverageListView.

BUG=719113
==========

[alph, 2017-05-10 19:06:18]

lgtm

https://codereview.chromium.org/2861393004/diff/60001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/devtools/front_end/coverage/CoverageDecorationManager.js
(right):

https://codereview.chromium.org/2861393004/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/coverage/CoverageDecorationManager.js:25:
// FIXME(crbug.com/720162): get rid of this, use bindings
TODO

https://codereview.chromium.org/2861393004/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/coverage/CoverageDecorationManager.js:148:
location.lineNumber -= script.lineOffset;
nit:
location.lineNumber -= script.lineOffset;
if (!location.lineNumber) ...

https://codereview.chromium.org/2861393004/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/coverage/CoverageDecorationManager.js:172:
location.lineNumber -= header.startLine;
ditto

https://codereview.chromium.org/2861393004/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/coverage/CoverageDecorationManager.js:184:
function comparePositions(aLine, aColumn, bLine, bColumn) {
annotate

https://codereview.chromium.org/2861393004/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/coverage/CoverageDecorationManager.js:191:
* FIXME(crbug.com/720162): get rid of this, use bindings
TODO

https://codereview.chromium.org/2861393004/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/coverage/CoverageDecorationManager.js:202:
var url = uiSourceCode.url();
move it to the usage

https://codereview.chromium.org/2861393004/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/coverage/CoverageDecorationManager.js:212:
this._documentUISouceCodeToStylesheets.set(uiSourceCode, stylesheets);
move it above the return to have it cached?

https://codereview.chromium.org/2861393004/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/coverage/CoverageDecorationManager.js:228:
* @param {!SDK.CSSStyleSheetHeader} b
@return

[caseq, 2017-05-10 22:04:47]

The CQ bit was checked by caseq@chromium.org

[caseq, 2017-05-10 22:04:47]

The patchset sent to the CQ was uploaded after l-g-t-m from alph@chromium.org
Link to the patchset: https://codereview.chromium.org/2861393004/#ps80001
(title: "Review comments addressed")

[commit-bot: I haz the power, 2017-05-10 22:05:51]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-11 00:14:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-11 00:14:27]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[caseq, 2017-05-11 00:37:43]

The CQ bit was checked by caseq@chromium.org

[caseq, 2017-05-11 00:37:45]

The patchset sent to the CQ was uploaded after l-g-t-m from alph@chromium.org
Link to the patchset: https://codereview.chromium.org/2861393004/#ps100001
(title: "reverted toFixedIfFloating() changes")

[commit-bot: I haz the power, 2017-05-11 00:38:40]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-11 04:01:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-11 04:01:09]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[caseq, 2017-05-11 16:26:16]

The CQ bit was checked by caseq@chromium.org

[commit-bot: I haz the power, 2017-05-11 16:26:59]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-11 18:05:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-11 18:05:36]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[caseq, 2017-05-11 19:46:19]

The CQ bit was checked by caseq@chromium.org

[commit-bot: I haz the power, 2017-05-11 19:47:20]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-11 22:41:16]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1494531979607200,
"parent_rev": "6a94be3b51f4a7d8b49ff2c4fb690dc12b7a6ae3", "commit_rev":
"3431436da14fb7b435d830f8552280333a7dee8c"}

[commit-bot: I haz the power, 2017-05-11 22:41:26]

Description was changed from

==========
DevTools/Coverage: fix decorations in HTML


- implement mapping for inline styles in HTML locally in
CoverageDecorationsManager as a workaound for bindings deficiencies;
- apply proper offsets to inline resources when mapping UI positions to resource
    byte offsets in CoverageDecorationsManager;
- (drive-by) improve bar sizing precision in CoverageListView.

BUG=719113
==========

to

==========
DevTools/Coverage: fix decorations in HTML


- implement mapping for inline styles in HTML locally in
CoverageDecorationsManager as a workaound for bindings deficiencies;
- apply proper offsets to inline resources when mapping UI positions to resource
    byte offsets in CoverageDecorationsManager;
- (drive-by) improve bar sizing precision in CoverageListView.

BUG=719113

Review-Url: https://codereview.chromium.org/2861393004
Cr-Commit-Position: refs/heads/master@{#471097}
Committed:
https://chromium.googlesource.com/chromium/src/+/3431436da14fb7b435d830f85522...
==========

[commit-bot: I haz the power, 2017-05-11 22:41:28]

Committed patchset #5 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/3431436da14fb7b435d830f85522...