MD Settings: Always provide recommended meta-data

MD Settings: Always provide recommended meta-data

Currently we only provide recommended meta-data for prefs
when pref->IsRecommended() is true, which is only true when
the user has not set the value.

We should provide meta-data whenever a policy provides a
recommended value for a pref.

BUG=532958
Review-Url: https://codereview.chromium.org/2861393003
Cr-Commit-Position: refs/heads/master@{#472513}
Committed: https://chromium.googlesource.com/chromium/src/+/28fe10df2390b039fe2209503421542963099dd6

[stevenjb, 2017-05-08 23:09:10]

Patchset #2 (id:20001) has been deleted

[stevenjb, 2017-05-08 23:10:04]

stevenjb@chromium.org changed reviewers:
+ dbeam@chromium.org

[stevenjb, 2017-05-08 23:10:05]

OK, the fix wasn't as bad as I feared. Writing the test was the painful part,
but at least now we have -something- in the way of policy testing.

[Dan Beam, 2017-05-10 18:30:42]

lgtm

[Dan Beam, 2017-05-10 18:32:20]

but are we gonna check how the UI shows these recommended things? do we still
want them to show off the user choose their recommended value? as in "You're
listening to the recommended by your administrator" when the effective value is
the same as recommended?

[stevenjb, 2017-05-10 18:37:19]

On 2017/05/10 18:32:20, Dan Beam wrote:
> but are we gonna check how the UI shows these recommended things? do we still
> want them to show off the user choose their recommended value? as in "You're
> listening to the recommended by your administrator" when the effective value
is
> the same as recommended?

That logic already exists and works. We compare the current value to the
recommended value to determine what message to show. (There's no distinction
between "this was set to the recommended value by policy" and "this was set to
the same value as the recommended value by the user").

(The UI for this is kind of weak imho, e.g. we don't show what the recommended
value *is* anywhere, or provide a link to the policy information, but that's a
separate issue).

[stevenjb, 2017-05-16 16:57:01]

The CQ bit was checked by stevenjb@chromium.org

[commit-bot: I haz the power, 2017-05-16 16:58:08]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-16 18:39:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-16 18:39:08]

Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Dan Beam, 2017-05-16 19:16:59]

Description was changed from

==========
MD Settimgs: Always provide recommended meta-data

Currently we only provide recommended meta-data for prefs
when pref->IsRecommended() is true, which is only true when
the user has not set the value.

We should provide meta-data whenever a policy provides a
recommended value for a pref.

BUG=532958
==========

to

==========
MD Settings: Always provide recommended meta-data

Currently we only provide recommended meta-data for prefs
when pref->IsRecommended() is true, which is only true when
the user has not set the value.

We should provide meta-data whenever a policy provides a
recommended value for a pref.

BUG=532958
==========

[stevenjb, 2017-05-16 21:01:50]

The CQ bit was checked by stevenjb@chromium.org

[stevenjb, 2017-05-16 21:01:51]

The patchset sent to the CQ was uploaded after l-g-t-m from dbeam@chromium.org
Link to the patchset: https://codereview.chromium.org/2861393003/#ps60001
(title: "Use non cros specific pref for tests")

[commit-bot: I haz the power, 2017-05-16 21:03:33]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-16 23:06:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-16 23:06:17]

Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[stevenjb, 2017-05-17 15:54:10]

The CQ bit was checked by stevenjb@chromium.org

[commit-bot: I haz the power, 2017-05-17 15:55:02]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-17 18:45:43]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1495036450932980,
"parent_rev": "0f41f67e8aad5ed714486a40555eae4cbb88a759", "commit_rev":
"28fe10df2390b039fe2209503421542963099dd6"}

[commit-bot: I haz the power, 2017-05-17 18:45:55]

Description was changed from

==========
MD Settings: Always provide recommended meta-data

Currently we only provide recommended meta-data for prefs
when pref->IsRecommended() is true, which is only true when
the user has not set the value.

We should provide meta-data whenever a policy provides a
recommended value for a pref.

BUG=532958
==========

to

==========
MD Settings: Always provide recommended meta-data

Currently we only provide recommended meta-data for prefs
when pref->IsRecommended() is true, which is only true when
the user has not set the value.

We should provide meta-data whenever a policy provides a
recommended value for a pref.

BUG=532958

Review-Url: https://codereview.chromium.org/2861393003
Cr-Commit-Position: refs/heads/master@{#472513}
Committed:
https://chromium.googlesource.com/chromium/src/+/28fe10df2390b039fe2209503421...
==========

[commit-bot: I haz the power, 2017-05-17 18:45:58]

Committed patchset #3 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/28fe10df2390b039fe2209503421...