Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2861393002:
Fix to include correct header files in jumplist.{h, cc} (Closed)
|
Created:
3 years, 7 months ago by chengx Modified:
3 years, 7 months ago Reviewers:
grt (UTC plus 2) CC:
chromium-reviews Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionFix to include correct header files in jumplist.{h, cc}
This CL fixes jumplist.{h, cc} to include some necessary header files
according to the iwyu (include-what-you-use) rule, and to remove some
others which are redundant.
BUG=719752
Review-Url: https://codereview.chromium.org/2861393002
Cr-Commit-Position: refs/heads/master@{#470659}
Committed: https://chromium.googlesource.com/chromium/src/+/5383621e52891f08341999f4e89a4def85b0b1cd
Patch Set 1 #
Total comments: 14
Patch Set 2 : Add some necessary ones, remove a few others #Patch Set 3 : Merge branch 'master' of https://chromium.googlesource.com/chromium/src into jumplistremoveutilityh… #Patch Set 4 : Delete more unused headers files #Patch Set 5 : Git pull #Messages
Total messages: 53 (47 generated)
The CQ bit was checked by chengx@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== remove redundant header files BUG= ========== to ========== Remove redundant header files included in jumplist.cc BUG= ==========
Description was changed from ========== Remove redundant header files included in jumplist.cc BUG= ========== to ========== Remove redundant header files included in jumplist.cc BUG=40407, 179576 ==========
Description was changed from ========== Remove redundant header files included in jumplist.cc BUG=40407, 179576 ========== to ========== Remove redundant header files included in jumplist.cc The <utility> header file is already included and used in jumplist.h, therefore we don't need to include it again in jumplist.cc BUG=40407, 179576 ==========
Description was changed from ========== Remove redundant header files included in jumplist.cc The <utility> header file is already included and used in jumplist.h, therefore we don't need to include it again in jumplist.cc BUG=40407, 179576 ========== to ========== Remove redundant header files included in jumplist.cc The <utility> header file is already included and used in jumplist.h, therefore we don't need to include it again in jumplist.cc BUG=40407, 179576 ==========
chengx@chromium.org changed reviewers: + grt@chromium.org
Hi Greg, PTAL at this small change, thanks!
i found a number of other iwyu fixups in the .cc and .h files looking just at std:: and base::. please make a thorough pass over all includes in both files. thanks. https://codereview.chromium.org/2861393002/diff/1/chrome/browser/win/jumplist.cc File chrome/browser/win/jumplist.cc (left): https://codereview.chromium.org/2861393002/diff/1/chrome/browser/win/jumplist... chrome/browser/win/jumplist.cc:7: #include <utility> while you're at it, please remove <vector> from the .h and add <memory> and base/memory/ref_counted.h to it https://codereview.chromium.org/2861393002/diff/1/chrome/browser/win/jumplist.cc File chrome/browser/win/jumplist.cc (right): https://codereview.chromium.org/2861393002/diff/1/chrome/browser/win/jumplist... chrome/browser/win/jumplist.cc:7: #include "base/bind.h" #include "base/base_paths.h" https://codereview.chromium.org/2861393002/diff/1/chrome/browser/win/jumplist... chrome/browser/win/jumplist.cc:11: #include "base/macros.h" remove; already included in .h https://codereview.chromium.org/2861393002/diff/1/chrome/browser/win/jumplist... chrome/browser/win/jumplist.cc:16: #include "base/strings/string_util.h" #include "base/strings/string16.h #include "base/strings/string_piece.h" https://codereview.chromium.org/2861393002/diff/1/chrome/browser/win/jumplist... chrome/browser/win/jumplist.cc:18: #include "base/task_scheduler/post_task.h" #include "base/task_scheduler/task_traits.h" https://codereview.chromium.org/2861393002/diff/1/chrome/browser/win/jumplist... chrome/browser/win/jumplist.cc:20: #include "base/threading/thread_restrictions.h" unused; remove https://codereview.chromium.org/2861393002/diff/1/chrome/browser/win/jumplist... chrome/browser/win/jumplist.cc:21: #include "base/timer/elapsed_timer.h" #include "base/time/time.h"
The CQ bit was checked by chengx@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Remove redundant header files included in jumplist.cc The <utility> header file is already included and used in jumplist.h, therefore we don't need to include it again in jumplist.cc BUG=40407, 179576 ========== to ========== Update header files included in jumplist.h and jumplist.cc BUG=40407, 179576 ==========
Description was changed from
==========
Update header files included in jumplist.h and jumplist.cc
BUG=40407, 179576
==========
to
==========
Update header files included in jumplist.{h, cc}
BUG=40407, 179576
==========
Description was changed from
==========
Update header files included in jumplist.{h, cc}
BUG=40407, 179576
==========
to
==========
Include correct header files in jumplist.{h, cc}
This CL fixes jumplist.{h, cc} to include some necessary header files
and to remove a few others which are redundant.
BUG=40407, 179576
==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from
==========
Include correct header files in jumplist.{h, cc}
This CL fixes jumplist.{h, cc} to include some necessary header files
and to remove a few others which are redundant.
BUG=40407, 179576
==========
to
==========
Fix to include correct header files in jumplist.{h, cc}
This CL fixes jumplist.{h, cc} to include some necessary header files
and to remove a few others which are redundant.
BUG=40407, 179576
==========
I removed a few more in jumplist.cc as they are included in jumplist.h already. https://codereview.chromium.org/2861393002/diff/1/chrome/browser/win/jumplist.cc File chrome/browser/win/jumplist.cc (left): https://codereview.chromium.org/2861393002/diff/1/chrome/browser/win/jumplist... chrome/browser/win/jumplist.cc:7: #include <utility> On 2017/05/08 08:42:23, grt (UTC plus 2) wrote: > while you're at it, please remove <vector> from the .h and add <memory> and > base/memory/ref_counted.h to it Done. https://codereview.chromium.org/2861393002/diff/1/chrome/browser/win/jumplist.cc File chrome/browser/win/jumplist.cc (right): https://codereview.chromium.org/2861393002/diff/1/chrome/browser/win/jumplist... chrome/browser/win/jumplist.cc:7: #include "base/bind.h" On 2017/05/08 08:42:23, grt (UTC plus 2) wrote: > #include "base/base_paths.h" Done. https://codereview.chromium.org/2861393002/diff/1/chrome/browser/win/jumplist... chrome/browser/win/jumplist.cc:11: #include "base/macros.h" On 2017/05/08 08:42:23, grt (UTC plus 2) wrote: > remove; already included in .h Done. https://codereview.chromium.org/2861393002/diff/1/chrome/browser/win/jumplist... chrome/browser/win/jumplist.cc:16: #include "base/strings/string_util.h" On 2017/05/08 08:42:23, grt (UTC plus 2) wrote: > #include "base/strings/string16.h > #include "base/strings/string_piece.h" Done. https://codereview.chromium.org/2861393002/diff/1/chrome/browser/win/jumplist... chrome/browser/win/jumplist.cc:18: #include "base/task_scheduler/post_task.h" On 2017/05/08 08:42:23, grt (UTC plus 2) wrote: > #include "base/task_scheduler/task_traits.h" Done. https://codereview.chromium.org/2861393002/diff/1/chrome/browser/win/jumplist... chrome/browser/win/jumplist.cc:20: #include "base/threading/thread_restrictions.h" On 2017/05/08 08:42:23, grt (UTC plus 2) wrote: > unused; remove Done. https://codereview.chromium.org/2861393002/diff/1/chrome/browser/win/jumplist... chrome/browser/win/jumplist.cc:21: #include "base/timer/elapsed_timer.h" On 2017/05/08 08:42:23, grt (UTC plus 2) wrote: > #include "base/time/time.h" "base/time/time.h" is already included in jumplist.h though.
lgtm
Description was changed from
==========
Fix to include correct header files in jumplist.{h, cc}
This CL fixes jumplist.{h, cc} to include some necessary header files
and to remove a few others which are redundant.
BUG=40407, 179576
==========
to
==========
Fix to include correct header files in jumplist.{h, cc}
This CL fixes jumplist.{h, cc} to include some necessary header files
and to remove a few others which are redundant.
BUG=719752
==========
The CQ bit was checked by chengx@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
The CQ bit was checked by chengx@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by chengx@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from
==========
Fix to include correct header files in jumplist.{h, cc}
This CL fixes jumplist.{h, cc} to include some necessary header files
and to remove a few others which are redundant.
BUG=719752
==========
to
==========
Fix to include correct header files in jumplist.{h, cc}
This CL fixes jumplist.{h, cc} to include some necessary header files
according to the iwyu (include-what-you-use) rule, and to remove some
others which are redundant.
BUG=719752
==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by chengx@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by chengx@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by chengx@chromium.org
The CQ bit was checked by chengx@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Patchset #5 (id:80001) has been deleted
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by chengx@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from grt@chromium.org Link to the patchset: https://codereview.chromium.org/2861393002/#ps100001 (title: "Git pull")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 100001, "attempt_start_ts": 1494441492491610,
"parent_rev": "c5cabd63ff5c51e67270774173cc0f66059cf341", "commit_rev":
"5383621e52891f08341999f4e89a4def85b0b1cd"}
Message was sent while issue was closed.
Description was changed from
==========
Fix to include correct header files in jumplist.{h, cc}
This CL fixes jumplist.{h, cc} to include some necessary header files
according to the iwyu (include-what-you-use) rule, and to remove some
others which are redundant.
BUG=719752
==========
to
==========
Fix to include correct header files in jumplist.{h, cc}
This CL fixes jumplist.{h, cc} to include some necessary header files
according to the iwyu (include-what-you-use) rule, and to remove some
others which are redundant.
BUG=719752
Review-Url: https://codereview.chromium.org/2861393002
Cr-Commit-Position: refs/heads/master@{#470659}
Committed:
https://chromium.googlesource.com/chromium/src/+/5383621e52891f08341999f4e89a...
==========
Message was sent while issue was closed.
Committed patchset #5 (id:100001) as https://chromium.googlesource.com/chromium/src/+/5383621e52891f08341999f4e89a... |
