Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Issue 2861373004: Add blink::WebInputEvent::IsPinchGestureEventType(). (Closed)

Created:
3 years, 7 months ago by Lei Zhang
Modified:
3 years, 7 months ago
Reviewers:
dtapuska, Nico, lazyboy
CC:
chromium-reviews, extensions-reviews_chromium.org, caseq+blink_chromium.org, alemate+watch_chromium.org, Matt Giuca, tfarina, achuith+watch_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, dglazkov+blink, apavlov+blink_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, devtools-reviews_chromium.org, blink-reviews, chromium-apps-reviews_chromium.org, kinuko+watch, blink-reviews-api_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add blink::WebInputEvent::IsPinchGestureEventType(). Review-Url: https://codereview.chromium.org/2861373004 Cr-Commit-Position: refs/heads/master@{#472185} Committed: https://chromium.googlesource.com/chromium/src/+/3df10ca837b3d45b1b8a3f4da796d40f595158e8

Patch Set 1 #

Total comments: 2

Patch Set 2 : WebInputEvent::Type #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -72 lines) Patch
M chrome/browser/chromeos/first_run/first_run_view.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/chromeos/login/ui/webui_login_view.cc View 1 2 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/devtools/devtools_window.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/extensions/extension_view_host.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/ui/app_list/start_page_service.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/ui/browser.cc View 2 chunks +1 line, -5 lines 0 comments Download
M components/guest_view/browser/guest_view_base.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M extensions/browser/app_window/app_web_contents_helper.cc View 1 chunk +1 line, -3 lines 0 comments Download
M extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest.cc View 1 chunk +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/web/DevToolsEmulator.cpp View 1 chunk +30 lines, -34 lines 0 comments Download
M third_party/WebKit/public/platform/WebInputEvent.h View 1 4 chunks +12 lines, -5 lines 0 comments Download
M ui/web_dialogs/web_dialog_web_contents_delegate.cc View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 32 (18 generated)
Lei Zhang
dtapuska: I remember you were changing WebInputEvent last year. Are you the right person to ...
3 years, 7 months ago (2017-05-08 19:10:19 UTC) #6
dtapuska
On 2017/05/08 19:10:19, Lei Zhang wrote: > dtapuska: I remember you were changing WebInputEvent last ...
3 years, 7 months ago (2017-05-08 19:19:42 UTC) #7
dtapuska
https://codereview.chromium.org/2861373004/diff/1/third_party/WebKit/public/platform/WebInputEvent.h File third_party/WebKit/public/platform/WebInputEvent.h (right): https://codereview.chromium.org/2861373004/diff/1/third_party/WebKit/public/platform/WebInputEvent.h#newcode316 third_party/WebKit/public/platform/WebInputEvent.h:316: static bool IsPinchGestureEventType(int type) { can you use WebInputEvent::Type ...
3 years, 7 months ago (2017-05-08 19:23:19 UTC) #8
Lei Zhang
https://codereview.chromium.org/2861373004/diff/1/third_party/WebKit/public/platform/WebInputEvent.h File third_party/WebKit/public/platform/WebInputEvent.h (right): https://codereview.chromium.org/2861373004/diff/1/third_party/WebKit/public/platform/WebInputEvent.h#newcode316 third_party/WebKit/public/platform/WebInputEvent.h:316: static bool IsPinchGestureEventType(int type) { On 2017/05/08 19:23:19, dtapuska ...
3 years, 7 months ago (2017-05-08 22:50:45 UTC) #10
Lei Zhang
OWNERS: lazyboy: components, extensions thakis: third_party/WebKit, ui
3 years, 7 months ago (2017-05-08 22:51:51 UTC) #12
lazyboy
extensions + guest view lgtm
3 years, 7 months ago (2017-05-08 22:59:27 UTC) #14
Lei Zhang
On 2017/05/08 22:51:51, Lei Zhang wrote: > thakis: third_party/WebKit, ui ping.
3 years, 7 months ago (2017-05-15 22:42:20 UTC) #17
Nico
lgtm Calling blink code from the browser is a bit questionable due to the chrome.dll ...
3 years, 7 months ago (2017-05-15 22:46:42 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2861373004/40001
3 years, 7 months ago (2017-05-16 01:01:58 UTC) #21
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/455350)
3 years, 7 months ago (2017-05-16 03:31:31 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2861373004/40001
3 years, 7 months ago (2017-05-16 05:58:22 UTC) #25
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/455511)
3 years, 7 months ago (2017-05-16 08:03:21 UTC) #27
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2861373004/40001
3 years, 7 months ago (2017-05-16 16:34:14 UTC) #29
commit-bot: I haz the power
3 years, 7 months ago (2017-05-16 19:36:02 UTC) #32
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/3df10ca837b3d45b1b8a3f4da796...

Powered by Google App Engine
This is Rietveld 408576698