Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(487)

Issue 2861323002: Revert "Add metrics for certificate report uploads" (Closed)

Created:
3 years, 7 months ago by Avi (use Gerrit)
Modified:
3 years, 7 months ago
Reviewers:
CC:
chromium-reviews, asvitkine+watch_chromium.org, grt+watch_chromium.org, vakh+watch_chromium.org, timvolodine
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "Add metrics for certificate report uploads" This reverts commit 19c49d0f04233c3a406d8171eddbe6209362ade5. BUG=682933 TBR=meacer@chromium.org NOTRY=true This fails on multiple platforms. https://build.chromium.org/p/chromium.win/builders/Win7%20%2832%29%20Tests/builds/19591 https://build.chromium.org/p/chromium.memory/builders/Linux%20MSan%20Tests/builds/626 [ RUN ] CertificateReportingServiceBrowserTest.DontSendOldReports Xlib: extension "RANDR" missing on display ":99". [17271:17271:0506/143918.081251:WARNING:audio_manager.cc(293)] Multiple instances of AudioManager detected [17271:17271:0506/143918.081331:WARNING:audio_manager.cc(254)] Multiple instances of AudioManager detected [17271:17271:0506/143918.348153:WARNING:password_store_factory.cc(249)] Using basic (unencrypted) store for password storage. See https://chromium.googlesource.com/chromium/src/+/master/docs/linux_password_storage.md for more information about password storage options. [17271:17271:0506/143919.432896:WARNING:navigator_impl.cc(269)] Discarding message during interstitial. [17271:17271:0506/143919.692333:ERROR:navigation_entry_screenshot_manager.cc(134)] Invalid entry with unique id: 1 [17271:17271:0506/143923.020192:WARNING:navigator_impl.cc(269)] Discarding message during interstitial. [17271:17271:0506/143923.219670:ERROR:navigation_entry_screenshot_manager.cc(134)] Invalid entry with unique id: 5 [17271:17271:0506/143926.470176:WARNING:navigator_impl.cc(269)] Discarding message during interstitial. ../../base/test/histogram_tester.cc:155: Failure Value of: actual_count Actual: 2 Expected: expected_count Which is: 3 Histogram "SSL.CertificateErrorReportEvent" does not have the right number of samples (3) in the expected bucket (3). It has (2). ../../base/test/histogram_tester.cc:170: Failure Value of: actual_count Actual: 12 Expected: expected_count Which is: 13 Histogram "SSL.CertificateErrorReportEvent" does not have the right total number of samples (13). It has (12). [ FAILED ] CertificateReportingServiceBrowserTest.DontSendOldReports, where TypeParam = and GetParam() = (10536 ms) Review-Url: https://codereview.chromium.org/2861323002 Cr-Commit-Position: refs/heads/master@{#469900} Committed: https://chromium.googlesource.com/chromium/src/+/e57c36727b93afd024eb70f36994ba4c28f88446

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -261 lines) Patch
M chrome/browser/safe_browsing/certificate_reporting_service.h View 2 chunks +0 lines, -23 lines 0 comments Download
M chrome/browser/safe_browsing/certificate_reporting_service.cc View 7 chunks +0 lines, -15 lines 0 comments Download
M chrome/browser/safe_browsing/certificate_reporting_service_browsertest.cc View 17 chunks +1 line, -67 lines 0 comments Download
M chrome/browser/safe_browsing/certificate_reporting_service_test_utils.h View 2 chunks +0 lines, -23 lines 0 comments Download
M chrome/browser/safe_browsing/certificate_reporting_service_test_utils.cc View 1 chunk +0 lines, -38 lines 0 comments Download
M chrome/browser/safe_browsing/certificate_reporting_service_unittest.cc View 19 chunks +2 lines, -79 lines 0 comments Download
M tools/metrics/histograms/enums.xml View 1 chunk +0 lines, -7 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +0 lines, -9 lines 0 comments Download

Messages

Total messages: 23 (13 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2861323002/1
3 years, 7 months ago (2017-05-06 22:40:33 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_tsan_rel_ng/builds/68447)
3 years, 7 months ago (2017-05-06 23:53:20 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2861323002/1
3 years, 7 months ago (2017-05-07 00:12:25 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/364407)
3 years, 7 months ago (2017-05-07 01:56:47 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2861323002/1
3 years, 7 months ago (2017-05-07 02:44:56 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/364433)
3 years, 7 months ago (2017-05-07 06:04:25 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2861323002/1
3 years, 7 months ago (2017-05-07 15:15:46 UTC) #15
Avi (use Gerrit)
On 2017/05/07 15:15:46, commit-bot: I haz the power wrote: > CQ is trying da patch. ...
3 years, 7 months ago (2017-05-07 16:49:01 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2861323002/1
3 years, 7 months ago (2017-05-07 16:49:27 UTC) #20
commit-bot: I haz the power
3 years, 7 months ago (2017-05-07 16:54:21 UTC) #23
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e57c36727b93afd024eb70f36994...

Powered by Google App Engine
This is Rietveld 408576698