[Mac] Refactor decoration divider code.

[Mac] Refactor decoration divider code.

Reorganizes the code that draws decoration dividers into a single
method.

R=spqchan@chromium.org,avi@chromium.org
BUG=621614, 719083
Review-Url: https://codereview.chromium.org/2861283002
Cr-Commit-Position: refs/heads/master@{#470004}
Committed: https://chromium.googlesource.com/chromium/src/+/f1ce80a582eece54780574857e8fdb8d7cef1acf

[shrike, 2017-05-05 22:50:31]

PTAL

[spqchan, 2017-05-05 23:00:15]

LGTM

https://codereview.chromium.org/2861283002/diff/1/chrome/browser/ui/cocoa/loc...
File chrome/browser/ui/cocoa/location_bar/location_bar_decoration.mm (right):

https://codereview.chromium.org/2861283002/diff/1/chrome/browser/ui/cocoa/loc...
chrome/browser/ui/cocoa/location_bar/location_bar_decoration.mm:446: if
(line_width < 1) {
[optional nit]: No curly braces

https://codereview.chromium.org/2861283002/diff/1/chrome/browser/ui/cocoa/loc...
chrome/browser/ui/cocoa/location_bar/location_bar_decoration.mm:455: if
(location_bar_is_dark) {
[optional nit]: No curly braces

https://codereview.chromium.org/2861283002/diff/1/chrome/browser/ui/cocoa/loc...
chrome/browser/ui/cocoa/location_bar/location_bar_decoration.mm:462:
divider_color = [divider_color colorWithAlphaComponent:alpha];
[optional nit]: No curly braces

[shrike, 2017-05-05 23:07:08]

https://codereview.chromium.org/2861283002/diff/1/chrome/browser/ui/cocoa/loc...
File chrome/browser/ui/cocoa/location_bar/location_bar_decoration.mm (right):

https://codereview.chromium.org/2861283002/diff/1/chrome/browser/ui/cocoa/loc...
chrome/browser/ui/cocoa/location_bar/location_bar_decoration.mm:446: if
(line_width < 1) {
On 2017/05/05 23:00:15, spqchan wrote:
> [optional nit]: No curly braces

Yeah, for simple if statements I opt for curly braces (I think it cuts down on
potential bugs).

[shrike, 2017-05-05 23:07:33]

Description was changed from

==========
[Mac] Refactor decoration divider code.

Reorganizes the code that draws decoration dividers into a single
method.

R=spqchan@chromium.org
BUG=621614
==========

to

==========
[Mac] Refactor decoration divider code.

Reorganizes the code that draws decoration dividers into a single
method.

R=spqchan@chromium.org,avi@chromium.org
BUG=621614
==========

[shrike, 2017-05-05 23:07:33]

shrike@chromium.org changed reviewers:
+ avi@chromium.org

[shrike, 2017-05-05 23:08:00]

avi@ - requesting owner's review.

[shrike, 2017-05-05 23:16:41]

Description was changed from

==========
[Mac] Refactor decoration divider code.

Reorganizes the code that draws decoration dividers into a single
method.

R=spqchan@chromium.org,avi@chromium.org
BUG=621614
==========

to

==========
[Mac] Refactor decoration divider code.

Reorganizes the code that draws decoration dividers into a single
method.

R=spqchan@chromium.org,avi@chromium.org
BUG=621614,719083
==========

[Avi (use Gerrit), 2017-05-06 03:24:47]

lgtm

stamp

[shrike, 2017-05-08 15:41:28]

The CQ bit was checked by shrike@chromium.org

[commit-bot: I haz the power, 2017-05-08 15:42:01]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-08 16:23:39]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1494258088680760, "parent_rev":
"e324edd539822b440ee78bd375f8dc0e284f39b6", "commit_rev":
"f1ce80a582eece54780574857e8fdb8d7cef1acf"}

[commit-bot: I haz the power, 2017-05-08 16:23:50]

Description was changed from

==========
[Mac] Refactor decoration divider code.

Reorganizes the code that draws decoration dividers into a single
method.

R=spqchan@chromium.org,avi@chromium.org
BUG=621614,719083
==========

to

==========
[Mac] Refactor decoration divider code.

Reorganizes the code that draws decoration dividers into a single
method.

R=spqchan@chromium.org,avi@chromium.org
BUG=621614,719083

Review-Url: https://codereview.chromium.org/2861283002
Cr-Commit-Position: refs/heads/master@{#470004}
Committed:
https://chromium.googlesource.com/chromium/src/+/f1ce80a582eece54780574857e8f...
==========

[commit-bot: I haz the power, 2017-05-08 16:23:51]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/f1ce80a582eece54780574857e8f...