Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Issue 2861263002: Shape Detection: move Java Face detection classes to //services/shape_detection (Closed)

Created:
3 years, 7 months ago by mcasas
Modified:
3 years, 7 months ago
Reviewers:
boliu
CC:
chromium-reviews, jam, nasko+codewatch_chromium.org, darin-cc_chromium.org, creis+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Shape Detection: move Java Face detection classes to //services/shape_detection This CL moves FaceDetection{Provider}Impl.java out of from //content/public/... and into //services/shape_detection to reunite with the other two fellas {Barcode,Text}DetectionImpl.java. Aside from it, this CL adds no new code, and is tested via ShapeDetectionBrowserTest. [1] https://cs.chromium.org/chromium/src/content/browser/shape_detection/shape_detection_browsertest.cc?type=cs&q=ShapeDetectionBrowserTest&sq=package:chromium&l=47 BUG=718275 Review-Url: https://codereview.chromium.org/2861263002 Cr-Commit-Position: refs/heads/master@{#469858} Committed: https://chromium.googlesource.com/chromium/src/+/50891e91c5ff7c763a5b053dc6b4385448c2a78c

Patch Set 1 #

Messages

Total messages: 10 (6 generated)
mcasas
boliu@ PTAL/RS plz the removal from content/
3 years, 7 months ago (2017-05-05 22:45:12 UTC) #4
boliu
lgtm
3 years, 7 months ago (2017-05-05 23:07:29 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2861263002/1
3 years, 7 months ago (2017-05-06 01:00:19 UTC) #7
commit-bot: I haz the power
3 years, 7 months ago (2017-05-06 18:59:47 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/50891e91c5ff7c763a5b053dc6b4...

Powered by Google App Engine
This is Rietveld 408576698