chromeos: Converts WorkspaceLayoutManager to aura::LayoutManager

chromeos: Converts WorkspaceLayoutManager to aura::LayoutManager

BUG=687657
TEST=covered by tests
R=msw@chromium.org

Review-Url: https://codereview.chromium.org/2861243003
Cr-Commit-Position: refs/heads/master@{#469993}
Committed: https://chromium.googlesource.com/chromium/src/+/3919a2d21a0c3df90ab7077aa6ebee97262dfd29

[sky, 2017-05-05 22:36:47]

The CQ bit was checked by sky@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-05 22:38:09]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-05 23:12:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-05 23:12:13]

Dry run: This issue passed the CQ dry run.

[msw, 2017-05-05 23:48:07]

lgtm with nits; so much conversion, so much still to do!

https://codereview.chromium.org/2861243003/diff/20001/ash/wm/fullscreen_windo...
File ash/wm/fullscreen_window_finder.cc (right):

https://codereview.chromium.org/2861243003/diff/20001/ash/wm/fullscreen_windo...
ash/wm/fullscreen_window_finder.cc:39: if
(GetWindowState((*iter))->IsUserPositionable() &&
nit: remove extra parens

https://codereview.chromium.org/2861243003/diff/20001/ash/wm/workspace_contro...
File ash/wm/workspace_controller.h (right):

https://codereview.chromium.org/2861243003/diff/20001/ash/wm/workspace_contro...
ash/wm/workspace_controller.h:13: #include "ui/aura/window.h"
optional nit: forward declare instead? (or remove incl from cc)

[sky, 2017-05-08 15:16:33]

The CQ bit was checked by sky@chromium.org

[sky, 2017-05-08 15:16:34]

The patchset sent to the CQ was uploaded after l-g-t-m from msw@chromium.org
Link to the patchset: https://codereview.chromium.org/2861243003/#ps40001
(title: "feedback")

[sky, 2017-05-08 15:16:37]

https://codereview.chromium.org/2861243003/diff/20001/ash/wm/fullscreen_windo...
File ash/wm/fullscreen_window_finder.cc (right):

https://codereview.chromium.org/2861243003/diff/20001/ash/wm/fullscreen_windo...
ash/wm/fullscreen_window_finder.cc:39: if
(GetWindowState((*iter))->IsUserPositionable() &&
On 2017/05/05 23:48:06, msw wrote:
> nit: remove extra parens

Done.

https://codereview.chromium.org/2861243003/diff/20001/ash/wm/workspace_contro...
File ash/wm/workspace_controller.h (right):

https://codereview.chromium.org/2861243003/diff/20001/ash/wm/workspace_contro...
ash/wm/workspace_controller.h:13: #include "ui/aura/window.h"
On 2017/05/05 23:48:06, msw wrote:
> optional nit: forward declare instead? (or remove incl from cc)

Done.

[commit-bot: I haz the power, 2017-05-08 15:17:06]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-08 15:52:33]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1494256593914160,
"parent_rev": "f6d4d348d9ebd6a7efeaf289c1c696d433c278ca", "commit_rev":
"3919a2d21a0c3df90ab7077aa6ebee97262dfd29"}

[commit-bot: I haz the power, 2017-05-08 15:52:48]

Description was changed from

==========
chromeos: Converts WorkspaceLayoutManager to aura::LayoutManager

BUG=687657
TEST=covered by tests
R=msw@chromium.org
==========

to

==========
chromeos: Converts WorkspaceLayoutManager to aura::LayoutManager

BUG=687657
TEST=covered by tests
R=msw@chromium.org

Review-Url: https://codereview.chromium.org/2861243003
Cr-Commit-Position: refs/heads/master@{#469993}
Committed:
https://chromium.googlesource.com/chromium/src/+/3919a2d21a0c3df90ab7077aa6eb...
==========

[commit-bot: I haz the power, 2017-05-08 15:52:49]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/3919a2d21a0c3df90ab7077aa6eb...