Record keep alive registry's state in stability instrumentation

Record keep alive registry's state in stability instrumentation

The registry may prevent shutdown which, even with crash reports, may
not necessarily be visible at end session (somewhat relevant bug:
https://crbug.com/707735).

BUG=719026
Review-Url: https://codereview.chromium.org/2861223003
Cr-Commit-Position: refs/heads/master@{#470122}
Committed: https://chromium.googlesource.com/chromium/src/+/ba8991ee197a4aea56536c6096fc8d35adfe454f

[manzagop (departed), 2017-05-05 21:20:43]

The CQ bit was checked by manzagop@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-05 21:22:16]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[manzagop (departed), 2017-05-05 21:25:47]

manzagop@chromium.org changed reviewers:
+ bcwhite@chromium.org

[manzagop (departed), 2017-05-05 21:25:47]

This is a quick one! Please have a look.

[commit-bot: I haz the power, 2017-05-05 23:05:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-05 23:05:32]

Dry run: This issue passed the CQ dry run.

[bcwhite, 2017-05-08 15:37:59]

https://codereview.chromium.org/2861223003/diff/1/chrome/browser/lifetime/kee...
File chrome/browser/lifetime/keep_alive_registry.cc (right):

https://codereview.chromium.org/2861223003/diff/1/chrome/browser/lifetime/kee...
chrome/browser/lifetime/keep_alive_registry.cc:13: #if defined(OS_WIN)
Why do this only on Windows?

https://codereview.chromium.org/2861223003/diff/1/components/metrics/executio...
File components/metrics/execution_phase.cc (right):

https://codereview.chromium.org/2861223003/diff/1/components/metrics/executio...
components/metrics/execution_phase.cc:12: #if defined(OS_WIN)
Why do this only on Windows?

[manzagop (departed), 2017-05-08 16:12:59]

https://codereview.chromium.org/2861223003/diff/1/chrome/browser/lifetime/kee...
File chrome/browser/lifetime/keep_alive_registry.cc (right):

https://codereview.chromium.org/2861223003/diff/1/chrome/browser/lifetime/kee...
chrome/browser/lifetime/keep_alive_registry.cc:13: #if defined(OS_WIN)
On 2017/05/08 15:37:59, bcwhite wrote:
> Why do this only on Windows?

I recently re-jigged the build targets for reuse by the crashing scenario and
felt it was simpler to make all build targets windows only for now, instead of
dealing with the complexity of multiple platforms (figuring what's is_win and
what's not among the dependencies). I'm thinking we can change this once we
tackle the other platforms.

https://codereview.chromium.org/2861223003/diff/1/components/metrics/executio...
File components/metrics/execution_phase.cc (right):

https://codereview.chromium.org/2861223003/diff/1/components/metrics/executio...
components/metrics/execution_phase.cc:12: #if defined(OS_WIN)
On 2017/05/08 15:37:59, bcwhite wrote:
> Why do this only on Windows?

Same as other comment.

[bcwhite, 2017-05-08 16:35:40]

lgtm

[manzagop (departed), 2017-05-08 18:00:38]

The CQ bit was checked by manzagop@chromium.org to run a CQ dry run

[manzagop (departed), 2017-05-08 18:00:40]

Thanks!

[commit-bot: I haz the power, 2017-05-08 18:01:18]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[manzagop (departed), 2017-05-08 18:01:38]

manzagop@chromium.org changed reviewers:
+ thestig@chromium.org

[manzagop (departed), 2017-05-08 18:01:39]

Hi Lei,
Could you have an OWNERS' look for chrome\browser\lifetime?
Thanks!
Pierre

[Lei Zhang, 2017-05-08 19:18:26]

lgtm

https://codereview.chromium.org/2861223003/diff/20001/chrome/browser/lifetime...
File chrome/browser/lifetime/keep_alive_registry.cc (right):

https://codereview.chromium.org/2861223003/diff/20001/chrome/browser/lifetime...
chrome/browser/lifetime/keep_alive_registry.cc:16: #endif  // defined(OS_WIN)
BTW, you don't really need the comment when the #if block is very short and when
this is not part of a nested #if block. If the list grows too long, git cl lint
will tell you.

[manzagop (departed), 2017-05-08 19:41:02]

Thanks for the review!

https://codereview.chromium.org/2861223003/diff/20001/chrome/browser/lifetime...
File chrome/browser/lifetime/keep_alive_registry.cc (right):

https://codereview.chromium.org/2861223003/diff/20001/chrome/browser/lifetime...
chrome/browser/lifetime/keep_alive_registry.cc:16: #endif  // defined(OS_WIN)
On 2017/05/08 19:18:26, Lei Zhang wrote:
> BTW, you don't really need the comment when the #if block is very short and
when
> this is not part of a nested #if block. If the list grows too long, git cl
lint
> will tell you.

Removed, here and below. Done.

[manzagop (departed), 2017-05-08 19:41:06]

The CQ bit was checked by manzagop@chromium.org

[manzagop (departed), 2017-05-08 19:41:07]

The patchset sent to the CQ was uploaded after l-g-t-m from
bcwhite@chromium.org, thestig@chromium.org
Link to the patchset: https://codereview.chromium.org/2861223003/#ps40001
(title: "Lighten ifdef comments")

[commit-bot: I haz the power, 2017-05-08 19:42:49]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-08 21:05:26]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1494272466862280,
"parent_rev": "7f48bb7b7fccc67eeb83d7e660893be03ae2f4ad", "commit_rev":
"ba8991ee197a4aea56536c6096fc8d35adfe454f"}

[commit-bot: I haz the power, 2017-05-08 21:05:34]

Description was changed from

==========
Record keep alive registry's state in stability instrumentation

The registry may prevent shutdown which, even with crash reports, may
not necessarily be visible at end session (somewhat relevant bug:
https://crbug.com/707735).

BUG=719026
==========

to

==========
Record keep alive registry's state in stability instrumentation

The registry may prevent shutdown which, even with crash reports, may
not necessarily be visible at end session (somewhat relevant bug:
https://crbug.com/707735).

BUG=719026

Review-Url: https://codereview.chromium.org/2861223003
Cr-Commit-Position: refs/heads/master@{#470122}
Committed:
https://chromium.googlesource.com/chromium/src/+/ba8991ee197a4aea56536c6096fc...
==========

[commit-bot: I haz the power, 2017-05-08 21:05:35]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/ba8991ee197a4aea56536c6096fc...