Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2861223002:
Add TRACE_EVENT_INSTANT_WITH_TIMESTAMP1. (Closed)
DescriptionAdd TRACE_EVENT_INSTANT_WITH_TIMESTAMP1.
Add TRACE_EVENT_INSTANT_WITH_TIMESTAMP1 to allow attaching argument to instant
events.
BUG=719687
Review-Url: https://codereview.chromium.org/2861223002
Cr-Commit-Position: refs/heads/master@{#470125}
Committed: https://chromium.googlesource.com/chromium/src/+/5add9bb55c86ff6bd0b4b19d90bbaee1e6ba1b3b
Patch Set 1 #
Messages
Total messages: 22 (13 generated)
The CQ bit was checked by lpy@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lpy@chromium.org changed reviewers: + fmeawad@chromium.org, oysteine@chromium.org
This is needed to produce page-load-metrics-based loading metrics through tracing. The basic idea here is that we add a cuid to each instant event to identify page load, eventually the cuid will come from GRC. See: https://docs.google.com/document/d/1fFTVFxvsOfd9DdAYPGDPXfHH3o3Pa0Po4rOfr1TYM...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
The CQ bit was checked by lpy@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
gentle ping for review.
lgtm
On 2017/05/08 20:32:31, fmeawad wrote: > lgtm Can you associate it to the bug where this is needed to understand the context?
On 2017/05/08 20:33:05, fmeawad wrote: > On 2017/05/08 20:32:31, fmeawad wrote: > > lgtm > > Can you associate it to the bug where this is needed to understand the context? Oystein: Does lpy needs to update other common files as well?
Description was changed from ========== Add TRACE_EVENT_INSTANT_WITH_TIMESTAMP1. Add TRACE_EVENT_INSTANT_WITH_TIMESTAMP1 to allow attaching argument to instant events. ========== to ========== Add TRACE_EVENT_INSTANT_WITH_TIMESTAMP1. Add TRACE_EVENT_INSTANT_WITH_TIMESTAMP1 to allow attaching argument to instant events. BUG=719687 ==========
On 2017/05/08 20:33:05, fmeawad wrote: > On 2017/05/08 20:32:31, fmeawad wrote: > > lgtm > > Can you associate it to the bug where this is needed to understand the context? done
On 2017/05/08 at 20:33:50, fmeawad wrote: > On 2017/05/08 20:33:05, fmeawad wrote: > > On 2017/05/08 20:32:31, fmeawad wrote: > > > lgtm > > > > Can you associate it to the bug where this is needed to understand the context? > > Oystein: Does lpy needs to update other common files as well? lgtm Nah, the file can just be copied on-demand.
The CQ bit was checked by lpy@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1494277077011940, "parent_rev":
"84b76aa34b7ee89ea7b44af59239f6729aa53ab5", "commit_rev":
"5add9bb55c86ff6bd0b4b19d90bbaee1e6ba1b3b"}
Message was sent while issue was closed.
Description was changed from ========== Add TRACE_EVENT_INSTANT_WITH_TIMESTAMP1. Add TRACE_EVENT_INSTANT_WITH_TIMESTAMP1 to allow attaching argument to instant events. BUG=719687 ========== to ========== Add TRACE_EVENT_INSTANT_WITH_TIMESTAMP1. Add TRACE_EVENT_INSTANT_WITH_TIMESTAMP1 to allow attaching argument to instant events. BUG=719687 Review-Url: https://codereview.chromium.org/2861223002 Cr-Commit-Position: refs/heads/master@{#470125} Committed: https://chromium.googlesource.com/chromium/src/+/5add9bb55c86ff6bd0b4b19d90bb... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/5add9bb55c86ff6bd0b4b19d90bb... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
