Workaround transform node NPE in PictureLayer::ShouldUseTransformedRasterization

Workaround transform node NPE in PictureLayer::ShouldUseTransformedRasterization

We have reports of crashes in PictureLayer::ShouldUseTransformedRasterization
due to the transform node of a picture layer being null. We do not think this
should be possible. This patch works around this issue by adding a DCHECK and
safely returning from the function.

This bug may be related to https://crbug.com/712298 which is a similar null
transform issue.

BUG=708951
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2861193002
Cr-Commit-Position: refs/heads/master@{#470001}
Committed: https://chromium.googlesource.com/chromium/src/+/cf4bbe815441d993ac26be4ae867807120b5755f

[pdr., 2017-05-05 18:19:41]

Description was changed from

==========
Workaround transform node NPE in PictureLayer::ShouldUseTransformedRasterization

We have reports of crashes in PictureLayer::ShouldUseTransformedRasterization
due to the transform node of a picture layer being null. We do not think this
should be possible. This patch works around this issue by adding a DCHECK and
safely returning from the function.

This bug may be related to https://crbug.com/712298 which is a similar null
transform issue.

BUG=708951
==========

to

==========
Workaround transform node NPE in PictureLayer::ShouldUseTransformedRasterization

We have reports of crashes in PictureLayer::ShouldUseTransformedRasterization
due to the transform node of a picture layer being null. We do not think this
should be possible. This patch works around this issue by adding a DCHECK and
safely returning from the function.

This bug may be related to https://crbug.com/712298 which is a similar null
transform issue.

BUG=708951
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[pdr., 2017-05-05 18:20:33]

pdr@chromium.org changed reviewers:
+ enne@chromium.org, jaydasika@chromium.org

[pdr., 2017-05-05 18:20:40]

The CQ bit was checked by pdr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-05 18:21:06]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jaydasika, 2017-05-05 18:56:33]

lgtm

I am ok with this workaround. At this point, we have a lot of DCHECKs in the
code which are trying to catch null property tree nodes/ invalid property trees.
Maybe we should consider making some of them CHECKs to get a proper repro ?

[pdr., 2017-05-05 19:02:17]

On 2017/05/05 at 18:56:33, jaydasika wrote:
> lgtm
> 
> I am ok with this workaround. At this point, we have a lot of DCHECKs in the
code which are trying to catch null property tree nodes/ invalid property trees.
Maybe we should consider making some of them CHECKs to get a proper repro ?

We have urls in crash/ for this but none of them are actually good repros :(

[enne (OOO), 2017-05-05 19:14:30]

lgtm too.  Thanks for the follow up.  :)

[commit-bot: I haz the power, 2017-05-05 20:52:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-05 20:52:41]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[pdr., 2017-05-05 20:54:55]

The CQ bit was checked by pdr@chromium.org

[commit-bot: I haz the power, 2017-05-05 20:55:45]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-06 01:33:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-06 01:33:17]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[pdr., 2017-05-06 01:46:55]

The CQ bit was checked by pdr@chromium.org

[commit-bot: I haz the power, 2017-05-06 01:47:44]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[pdr., 2017-05-06 14:53:37]

The CQ bit was unchecked by pdr@chromium.org

[pdr., 2017-05-06 14:53:39]

The CQ bit was checked by pdr@chromium.org

[commit-bot: I haz the power, 2017-05-06 14:53:59]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-06 19:51:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-06 19:51:58]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[pdr., 2017-05-06 19:58:55]

The CQ bit was checked by pdr@chromium.org

[commit-bot: I haz the power, 2017-05-06 19:59:05]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-06 21:26:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-06 21:26:11]

Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[pdr., 2017-05-08 14:42:59]

The CQ bit was checked by pdr@chromium.org

[commit-bot: I haz the power, 2017-05-08 14:43:21]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-08 16:19:35]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1494254579184360, "parent_rev":
"23b6070530a8d074331da0dba161513f389b2077", "commit_rev":
"cf4bbe815441d993ac26be4ae867807120b5755f"}

[commit-bot: I haz the power, 2017-05-08 16:19:49]

Description was changed from

==========
Workaround transform node NPE in PictureLayer::ShouldUseTransformedRasterization

We have reports of crashes in PictureLayer::ShouldUseTransformedRasterization
due to the transform node of a picture layer being null. We do not think this
should be possible. This patch works around this issue by adding a DCHECK and
safely returning from the function.

This bug may be related to https://crbug.com/712298 which is a similar null
transform issue.

BUG=708951
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
Workaround transform node NPE in PictureLayer::ShouldUseTransformedRasterization

We have reports of crashes in PictureLayer::ShouldUseTransformedRasterization
due to the transform node of a picture layer being null. We do not think this
should be possible. This patch works around this issue by adding a DCHECK and
safely returning from the function.

This bug may be related to https://crbug.com/712298 which is a similar null
transform issue.

BUG=708951
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2861193002
Cr-Commit-Position: refs/heads/master@{#470001}
Committed:
https://chromium.googlesource.com/chromium/src/+/cf4bbe815441d993ac26be4ae867...
==========

[commit-bot: I haz the power, 2017-05-08 16:19:50]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/cf4bbe815441d993ac26be4ae867...