Add --use-ime-service command line flag to enable InputMethodMus in --mus.

Add --use-ime-service command line flag to enable InputMethodMus in --mus.

BUG=706913
Review-Url: https://codereview.chromium.org/2861173002
Cr-Commit-Position: refs/heads/master@{#469724}
Committed: https://chromium.googlesource.com/chromium/src/+/c229a523deb5c69d49f4757d471eb206f6305ca3

[Hadi, 2017-05-05 13:24:25]

The CQ bit was checked by moshayedi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-05 13:24:42]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Hadi, 2017-05-05 13:25:58]

moshayedi@chromium.org changed reviewers:
+ sadrul@chromium.org, sky@chromium.org

[Hadi, 2017-05-05 13:25:59]

PTAL.

[sky, 2017-05-05 13:35:40]

Can you elaborate on why we want this and where we will use it? I thought we
want classic IME for --mus?

[Hadi, 2017-05-05 13:44:16]

On 2017/05/05 13:35:40, sky wrote:
> Can you elaborate on why we want this and where we will use it? I thought we
> want classic IME for --mus?

My understanding from a discussion couple of weeks ago was to use classic IME by
default and provide a flag to enable servicified IME so we are able to try it in
--mus and assess if servicified IME is at a stage to be turned on permanently. I
probably misunderstood the discussion.

If this is not needed, I'll close this.

[sadrul, 2017-05-05 14:08:24]

On 2017/05/05 13:44:16, Hadi wrote:
> On 2017/05/05 13:35:40, sky wrote:
> > Can you elaborate on why we want this and where we will use it? I thought we
> > want classic IME for --mus?
> 
> My understanding from a discussion couple of weeks ago was to use classic IME
by
> default and provide a flag to enable servicified IME so we are able to try it
in
> --mus and assess if servicified IME is at a stage to be turned on permanently.
I
> probably misunderstood the discussion.
> 
> If this is not needed, I'll close this.

I think we can continue to use --mash for developing/testing ime. Once it's done
for --mash, we can experiment turning it on for --mus too.

[sky, 2017-05-05 14:22:36]

That makes sense.

https://codereview.chromium.org/2861173002/diff/1/ash/ash_switches.cc
File ash/ash_switches.cc (right):

https://codereview.chromium.org/2861173002/diff/1/ash/ash_switches.cc#newcode112
ash/ash_switches.cc:112: const char kUseServicifiedIME[] =
"use-servicified-ime";
'serficified' is a bit unusual of a name. How about naming this
--use-ime-service and update the description appropriately?

https://codereview.chromium.org/2861173002/diff/1/ash/display/window_tree_hos...
File ash/display/window_tree_host_manager.cc (left):

https://codereview.chromium.org/2861173002/diff/1/ash/display/window_tree_hos...
ash/display/window_tree_host_manager.cc:830: DCHECK(!host->has_input_method());
It would be nice to keep this DCHECK. Otherwise if we accidentally install an
InputMethod we won't know.

[Hadi, 2017-05-05 14:24:07]

Description was changed from

==========
Add --use-servicified-ime command line flag to enable InputMethodMus in --mus.

BUG=706913
==========

to

==========
Add --use-servicified-ime command line flag to enable InputMethodMus in --mus.

BUG=706913
==========

[Hadi, 2017-05-05 14:39:49]

The CQ bit was checked by moshayedi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-05 14:40:01]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Hadi, 2017-05-05 14:50:06]

The CQ bit was checked by moshayedi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-05 14:50:30]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Hadi, 2017-05-05 14:51:58]

https://codereview.chromium.org/2861173002/diff/1/ash/ash_switches.cc
File ash/ash_switches.cc (right):

https://codereview.chromium.org/2861173002/diff/1/ash/ash_switches.cc#newcode112
ash/ash_switches.cc:112: const char kUseServicifiedIME[] =
"use-servicified-ime";
On 2017/05/05 14:22:36, sky wrote:
> 'serficified' is a bit unusual of a name. How about naming this
> --use-ime-service and update the description appropriately?

Done.

https://codereview.chromium.org/2861173002/diff/1/ash/display/window_tree_hos...
File ash/display/window_tree_host_manager.cc (left):

https://codereview.chromium.org/2861173002/diff/1/ash/display/window_tree_hos...
ash/display/window_tree_host_manager.cc:830: DCHECK(!host->has_input_method());
On 2017/05/05 14:22:36, sky wrote:
> It would be nice to keep this DCHECK. Otherwise if we accidentally install an
> InputMethod we won't know.

Done. Also refactored the condition to Shell::UseIMEService() to not repeat it
in 3 places.

[Hadi, 2017-05-05 15:01:41]

Description was changed from

==========
Add --use-servicified-ime command line flag to enable InputMethodMus in --mus.

BUG=706913
==========

to

==========
Add --use-ime-service command line flag to enable InputMethodMus in --mus.

BUG=706913
==========

[commit-bot: I haz the power, 2017-05-05 15:32:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-05 15:32:56]

Dry run: This issue passed the CQ dry run.

[sky, 2017-05-05 17:08:08]

LGTM

https://codereview.chromium.org/2861173002/diff/40001/ash/shell.h
File ash/shell.h (right):

https://codereview.chromium.org/2861173002/diff/40001/ash/shell.h#newcode261
ash/shell.h:261: static bool UseIMEService();
'UseIMEService' reads a verb, where as this is information. How about
ShouldUseImeService?

[Hadi, 2017-05-05 17:26:50]

The CQ bit was checked by moshayedi@chromium.org

[Hadi, 2017-05-05 17:26:56]

The CQ bit was unchecked by moshayedi@chromium.org

[Hadi, 2017-05-05 17:27:13]

The CQ bit was checked by moshayedi@chromium.org

[Hadi, 2017-05-05 17:27:13]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org
Link to the patchset: https://codereview.chromium.org/2861173002/#ps60001
(title: "Addressed feedback.")

[Hadi, 2017-05-05 17:27:40]

https://codereview.chromium.org/2861173002/diff/40001/ash/shell.h
File ash/shell.h (right):

https://codereview.chromium.org/2861173002/diff/40001/ash/shell.h#newcode261
ash/shell.h:261: static bool UseIMEService();
On 2017/05/05 17:08:08, sky wrote:
> 'UseIMEService' reads a verb, where as this is information. How about
> ShouldUseImeService?

Done.

[commit-bot: I haz the power, 2017-05-05 17:27:51]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-05 18:14:30]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1494005233097130,
"parent_rev": "7d79de54da67baa636ec73515cf130946970d6f9", "commit_rev":
"c229a523deb5c69d49f4757d471eb206f6305ca3"}

[commit-bot: I haz the power, 2017-05-05 18:15:06]

Description was changed from

==========
Add --use-ime-service command line flag to enable InputMethodMus in --mus.

BUG=706913
==========

to

==========
Add --use-ime-service command line flag to enable InputMethodMus in --mus.

BUG=706913

Review-Url: https://codereview.chromium.org/2861173002
Cr-Commit-Position: refs/heads/master@{#469724}
Committed:
https://chromium.googlesource.com/chromium/src/+/c229a523deb5c69d49f4757d471e...
==========

[commit-bot: I haz the power, 2017-05-05 18:15:07]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/c229a523deb5c69d49f4757d471e...