Make single_sample_metrics into its own target

Make single_sample_metrics into its own target

This CL makes single_sample_metrics into its own target so consumers who depend
on components/metrics can avoid pulling in the dependency if desired.

crrev.com/2687583002 increased cronet debug binary size by 40% (3.5MB) and
release binary size by 4% (300KB). The effect is not seen on all architectures,
but we should try to limit the impact.

BUG=718833
Review-Url: https://codereview.chromium.org/2861153002
Cr-Commit-Position: refs/heads/master@{#470094}
Committed: https://chromium.googlesource.com/chromium/src/+/a59254424997b8dc543d3d2a3315f707d5c07c79

[xunjieli, 2017-05-05 13:12:35]

The CQ bit was checked by xunjieli@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-05 13:12:48]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-05 13:16:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-05 13:16:21]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[xunjieli, 2017-05-05 13:28:36]

The CQ bit was checked by xunjieli@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-05 13:28:49]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-05 13:32:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-05 13:32:26]

Dry run: Try jobs failed on following builders:
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)

[xunjieli, 2017-05-05 13:37:43]

The CQ bit was checked by xunjieli@chromium.org to run a CQ dry run

[xunjieli, 2017-05-05 13:38:04]

Patchset #1 (id:1) has been deleted

[commit-bot: I haz the power, 2017-05-05 13:38:04]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[xunjieli, 2017-05-05 13:44:18]

xunjieli@chromium.org changed reviewers:
+ asvitkine@chromium.org

[xunjieli, 2017-05-05 13:44:19]

asvitkine@: I think this is compiling (at least locally). 
Is this the right approach? PTAL.

[xunjieli, 2017-05-05 13:49:13]

On 2017/05/05 13:44:19, xunjieli wrote:
> asvitkine@: I think this is compiling (at least locally). 
> Is this the right approach? PTAL.

With this CL, libcronet.so returns to the original size:
  File: ‘out/Debug/cronet/libs/armeabi-v7a/libcronet.60.0.3091.0.so’
  Size: 8441068         Blocks: 16488      IO Block: 4096   regular file

  File: ‘out/Debug/cronet/libs/armeabi-v7a/libcronet.60.0.3091.0.so’
  Size: 6101800         Blocks: 11920      IO Block: 4096   regular file

A 38% decrease.

[commit-bot: I haz the power, 2017-05-05 14:48:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-05 14:48:47]

Dry run: This issue passed the CQ dry run.

[Alexei Svitkine (slow), 2017-05-05 15:23:02]

lgtm

[xunjieli, 2017-05-05 15:31:53]

Description was changed from

==========
Make single_sample_metrics into its own target

This CL makes single_sample_metrics into its own target so consumers who depend
on components/metrics can avoid pulling in the dependency if desired.

crrev.com/2687583002 increased cronet debug binary size by 40% (3.5MB) and
release binary size by 4% (300KB). The effect is not seen on all architectures,
but we should try to limit the impact.

BUG=718833
==========

to

==========
Make single_sample_metrics into its own target

This CL makes single_sample_metrics into its own target so consumers who depend
on components/metrics can avoid pulling in the dependency if desired.

crrev.com/2687583002 increased cronet debug binary size by 40% (3.5MB) and
release binary size by 4% (300KB). The effect is not seen on all architectures,
but we should try to limit the impact.

BUG=718833
==========

[xunjieli, 2017-05-05 15:31:53]

xunjieli@chromium.org changed reviewers:
+ jam@chromium.org

[xunjieli, 2017-05-05 15:32:17]

+ jam@: could you do an owner review for content/ ? Thanks.

[jam, 2017-05-08 15:03:32]

lgtm

[xunjieli, 2017-05-08 16:34:08]

The CQ bit was checked by xunjieli@chromium.org

[commit-bot: I haz the power, 2017-05-08 16:34:55]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-08 16:52:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-08 16:52:19]

Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[xunjieli, 2017-05-08 19:27:30]

The CQ bit was checked by xunjieli@chromium.org

[commit-bot: I haz the power, 2017-05-08 19:28:22]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-08 20:01:52]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1494271650261020,
"parent_rev": "ebd3740c435c3e5ff370b87668ef9001385507c1", "commit_rev":
"a59254424997b8dc543d3d2a3315f707d5c07c79"}

[commit-bot: I haz the power, 2017-05-08 20:02:00]

Description was changed from

==========
Make single_sample_metrics into its own target

This CL makes single_sample_metrics into its own target so consumers who depend
on components/metrics can avoid pulling in the dependency if desired.

crrev.com/2687583002 increased cronet debug binary size by 40% (3.5MB) and
release binary size by 4% (300KB). The effect is not seen on all architectures,
but we should try to limit the impact.

BUG=718833
==========

to

==========
Make single_sample_metrics into its own target

This CL makes single_sample_metrics into its own target so consumers who depend
on components/metrics can avoid pulling in the dependency if desired.

crrev.com/2687583002 increased cronet debug binary size by 40% (3.5MB) and
release binary size by 4% (300KB). The effect is not seen on all architectures,
but we should try to limit the impact.

BUG=718833

Review-Url: https://codereview.chromium.org/2861153002
Cr-Commit-Position: refs/heads/master@{#470094}
Committed:
https://chromium.googlesource.com/chromium/src/+/a59254424997b8dc543d3d2a3315...
==========

[commit-bot: I haz the power, 2017-05-08 20:02:02]

Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/a59254424997b8dc543d3d2a3315...