Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Issue 2861143002: Fix tracing in escape-analysis.cc. (Closed)

Created:
3 years, 7 months ago by Ilija.Pavlovic1
Modified:
3 years, 7 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

Fix tracing in escape-analysis.cc. With this adaptation build V8 in Debug mode will be finished without error messages. TEST= BUG= Review-Url: https://codereview.chromium.org/2861143002 Cr-Commit-Position: refs/heads/master@{#45137} Committed: https://chromium.googlesource.com/v8/v8/+/b9cebf8c9edae76c7036ef5090e5040d000576c4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -5 lines) Patch
M src/compiler/escape-analysis.cc View 3 chunks +8 lines, -5 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
Ilija.Pavlovic1
PTAL
3 years, 7 months ago (2017-05-05 12:48:16 UTC) #2
Tobias Tebbi
On 2017/05/05 12:48:16, Ilija.Pavlovic1 wrote: > PTAL oh, yes, thank you! lgtm
3 years, 7 months ago (2017-05-05 12:51:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2861143002/1
3 years, 7 months ago (2017-05-05 12:52:11 UTC) #5
commit-bot: I haz the power
3 years, 7 months ago (2017-05-05 13:19:49 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/b9cebf8c9edae76c7036ef5090e5040d000...

Powered by Google App Engine
This is Rietveld 408576698