Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(319)

Unified Diff: base/trace_event/heap_profiler_serialization_state.h

Issue 2861133002: memory-infra: Move dump level check to observer and rename session state (Closed)
Patch Set: move comment Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/trace_event/heap_profiler_serialization_state.h
diff --git a/base/trace_event/memory_dump_session_state.h b/base/trace_event/heap_profiler_serialization_state.h
similarity index 82%
rename from base/trace_event/memory_dump_session_state.h
rename to base/trace_event/heap_profiler_serialization_state.h
index 46092cb4832d7d8d69f51cfadd143760c26b0b15..3d388b209c580719127eecd8521fc8982f895b59 100644
--- a/base/trace_event/memory_dump_session_state.h
+++ b/base/trace_event/heap_profiler_serialization_state.h
@@ -2,8 +2,8 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#ifndef BASE_TRACE_EVENT_MEMORY_DUMP_SESSION_STATE_H_
-#define BASE_TRACE_EVENT_MEMORY_DUMP_SESSION_STATE_H_
+#ifndef BASE_TRACE_EVENT_HEAP_PROFILER_SERIALIZATION_STATE_H_
+#define BASE_TRACE_EVENT_HEAP_PROFILER_SERIALIZATION_STATE_H_
#include <memory>
#include <set>
@@ -18,10 +18,10 @@ namespace trace_event {
// Container for state variables that should be shared across all the memory
// dumps in a tracing session.
-class BASE_EXPORT MemoryDumpSessionState
- : public RefCountedThreadSafe<MemoryDumpSessionState> {
+class BASE_EXPORT HeapProfilerSerializationState
+ : public RefCountedThreadSafe<HeapProfilerSerializationState> {
public:
- MemoryDumpSessionState();
+ HeapProfilerSerializationState();
// Returns the stack frame deduplicator that should be used by memory dump
// providers when doing a heap dump.
@@ -55,8 +55,8 @@ class BASE_EXPORT MemoryDumpSessionState
}
private:
- friend class RefCountedThreadSafe<MemoryDumpSessionState>;
- ~MemoryDumpSessionState();
+ friend class RefCountedThreadSafe<HeapProfilerSerializationState>;
+ ~HeapProfilerSerializationState();
// Deduplicates backtraces in heap dumps so they can be written once when the
// trace is finalized.
@@ -66,12 +66,10 @@ class BASE_EXPORT MemoryDumpSessionState
// trace is finalized.
std::unique_ptr<TypeNameDeduplicator> type_name_deduplicator_;
- std::set<MemoryDumpLevelOfDetail> allowed_dump_modes_;
-
uint32_t heap_profiler_breakdown_threshold_bytes_;
};
} // namespace trace_event
} // namespace base
-#endif // BASE_TRACE_EVENT_MEMORY_DUMP_SESSION_STATE_H_
+#endif // BASE_TRACE_EVENT_HEAP_PROFILER_SERIALIZATION_STATE_H

Powered by Google App Engine
This is Rietveld 408576698