Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3232)

Unified Diff: base/trace_event/heap_profiler_serialization_state.cc

Issue 2861133002: memory-infra: Move dump level check to observer and rename session state (Closed)
Patch Set: move comment Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/trace_event/heap_profiler_serialization_state.cc
diff --git a/base/trace_event/memory_dump_session_state.cc b/base/trace_event/heap_profiler_serialization_state.cc
similarity index 53%
rename from base/trace_event/memory_dump_session_state.cc
rename to base/trace_event/heap_profiler_serialization_state.cc
index d26b82a5b74c65f774403eb7fae1cc88ba556f7f..d332d43c4710cfb08e75194b3333134ec84e507e 100644
--- a/base/trace_event/memory_dump_session_state.cc
+++ b/base/trace_event/heap_profiler_serialization_state.cc
@@ -2,36 +2,26 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#include "base/trace_event/memory_dump_session_state.h"
+#include "base/trace_event/heap_profiler_serialization_state.h"
namespace base {
namespace trace_event {
-MemoryDumpSessionState::MemoryDumpSessionState()
+HeapProfilerSerializationState::HeapProfilerSerializationState()
: heap_profiler_breakdown_threshold_bytes_(0) {}
-MemoryDumpSessionState::~MemoryDumpSessionState() {}
+HeapProfilerSerializationState::~HeapProfilerSerializationState() {}
-void MemoryDumpSessionState::SetStackFrameDeduplicator(
+void HeapProfilerSerializationState::SetStackFrameDeduplicator(
std::unique_ptr<StackFrameDeduplicator> stack_frame_deduplicator) {
DCHECK(!stack_frame_deduplicator_);
stack_frame_deduplicator_ = std::move(stack_frame_deduplicator);
}
-void MemoryDumpSessionState::SetTypeNameDeduplicator(
+void HeapProfilerSerializationState::SetTypeNameDeduplicator(
std::unique_ptr<TypeNameDeduplicator> type_name_deduplicator) {
DCHECK(!type_name_deduplicator_);
type_name_deduplicator_ = std::move(type_name_deduplicator);
}
-void MemoryDumpSessionState::SetAllowedDumpModes(
- std::set<MemoryDumpLevelOfDetail> allowed_dump_modes) {
- allowed_dump_modes_ = allowed_dump_modes;
-}
-
-bool MemoryDumpSessionState::IsDumpModeAllowed(
- MemoryDumpLevelOfDetail dump_mode) const {
- return allowed_dump_modes_.count(dump_mode) != 0;
-}
-
} // namespace trace_event
} // namespace base

Powered by Google App Engine
This is Rietveld 408576698