Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2861113002:
[wasm] Add simd lowering for I16x8Neg (Closed)
|
Created:
3 years, 7 months ago by dusan.simicic Modified:
3 years, 7 months ago CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com Target Ref:
refs/heads/master Project:
v8 Visibility:
Public. |
Description[wasm] Add simd lowering for I16x8Neg
BUG=
Review-Url: https://codereview.chromium.org/2861113002
Cr-Commit-Position: refs/heads/master@{#45320}
Committed: https://chromium.googlesource.com/v8/v8/+/35c850e5c564b793eb354bb5d6d694906cb4b6e2
Patch Set 1 #Patch Set 2 : Enable I16x8Neg test for SIMD_LOWERING_TARGET #
Messages
Total messages: 25 (13 generated)
dusan.simicic@imgtec.com changed reviewers: + aseemgarg@chromium.org, bbudge@chromium.org, mtrofin@chromium.org
PTAL
lgtm. Please enable the corresponding test in test-run-wasm-simd before submitting.
The CQ bit was checked by dusan.simicic@imgtec.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by dusan.simicic@imgtec.com
The patchset sent to the CQ was uploaded after l-g-t-m from aseemgarg@chromium.org Link to the patchset: https://codereview.chromium.org/2861113002/#ps20001 (title: "Enable I16x8Neg test for SIMD_LOWERING_TARGET")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: v8_presubmit on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/40616)
dusan.simicic@imgtec.com changed reviewers: + tebbi@chromium.org, titzer@chromium.org
+ tebbi, + titzer PTAL
On 2017/05/08 11:24:50, dusan.simicic wrote: > + tebbi, + titzer > PTAL + bmeurer
tebbi@chromium.org changed reviewers: + bmeurer@chromium.org - titzer@chromium.org
Still need lgtm from owner. PTAL
On 2017/05/15 14:51:26, dusan.simicic wrote: > Still need lgtm from owner. PTAL Rubber-stamp lgtm
On 2017/05/15 19:37:24, mtrofin1 wrote: > On 2017/05/15 14:51:26, dusan.simicic wrote: > > Still need lgtm from owner. PTAL > > Rubber-stamp lgtm Using the right account this time - lgtm
The CQ bit was checked by mtrofin@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1494879623559900,
"parent_rev": "7a581fa28f9c0829e0e93085fce4cbb59b0c9639", "commit_rev":
"35c850e5c564b793eb354bb5d6d694906cb4b6e2"}
Message was sent while issue was closed.
Description was changed from ========== [wasm] Add simd lowering for I16x8Neg BUG= ========== to ========== [wasm] Add simd lowering for I16x8Neg BUG= Review-Url: https://codereview.chromium.org/2861113002 Cr-Commit-Position: refs/heads/master@{#45320} Committed: https://chromium.googlesource.com/v8/v8/+/35c850e5c564b793eb354bb5d6d694906cb... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/v8/v8/+/35c850e5c564b793eb354bb5d6d694906cb... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
