Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 2861093004: [runtime] MigrateFastToFast: fix check for unboxed inobject doubles (Closed)

Created:
3 years, 7 months ago by Jakob Kummerow
Modified:
3 years, 7 months ago
Reviewers:
Igor Sheludko
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[runtime] MigrateFastToFast: fix check for unboxed inobject doubles After the recent fast-property deletion changes, there can be a non-empty out-of-object backing store (that previously held properties) even though the next double property will be stored in-object. BUG=chromium:718779 Review-Url: https://codereview.chromium.org/2861093004 Cr-Commit-Position: refs/heads/master@{#45146} Committed: https://chromium.googlesource.com/v8/v8/+/ceba405f28a6b20814107930365788f2749db574

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -3 lines) Patch
M src/objects.cc View 1 chunk +2 lines, -3 lines 0 comments Download
A test/mjsunit/regress/regress-crbug-718779.js View 1 chunk +21 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
Jakob Kummerow
PTAL.
3 years, 7 months ago (2017-05-05 16:10:09 UTC) #2
Igor Sheludko
lgtm (I added [runtime] to the description).
3 years, 7 months ago (2017-05-05 17:48:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2861093004/1
3 years, 7 months ago (2017-05-05 21:48:37 UTC) #6
commit-bot: I haz the power
3 years, 7 months ago (2017-05-05 22:23:13 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/ceba405f28a6b20814107930365788f2749...

Powered by Google App Engine
This is Rietveld 408576698