Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 2861093003: Unbreak clang/win tot bots after clang r302190 (Closed)

Created:
3 years, 7 months ago by Nico
Modified:
3 years, 7 months ago
Reviewers:
hans
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Unbreak clang/win tot bots after clang r302190 r302190 enabled -Wmicrosoft-enum-forward-reference by default. Explicitly turn it off until the codebase can build with it on. BUG=718880 TBR=hans@chromium.org Review-Url: https://codereview.chromium.org/2861093003 . Cr-Commit-Position: refs/heads/master@{#469650} Committed: https://chromium.googlesource.com/chromium/src/+/0bc26848be0c12d776ddaa89ebcb36efcb2d2b7c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M build/config/compiler/BUILD.gn View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Nico
3 years, 7 months ago (2017-05-05 14:45:38 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2861093003/1
3 years, 7 months ago (2017-05-05 14:46:02 UTC) #4
Nico
Committed patchset #1 (id:1) manually as 0bc26848be0c12d776ddaa89ebcb36efcb2d2b7c (presubmit successful).
3 years, 7 months ago (2017-05-05 15:12:22 UTC) #6
hans
3 years, 7 months ago (2017-05-05 15:31:47 UTC) #7
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698